Changeset 72481 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jun 8, 2018 12:46:07 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

122966

Message:

FE/Qt bugref:9184 When hardware acceleration is enabled for the vm and not supported by the host, warn the user and let him disable it

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp

@@ -483 +483 @@
             messages << message;
     }
-
+    /* Acceleration tab: */
+    {
+        /* Prepare message: */
+        UIValidationMessage message;
+        message.first = VBoxGlobal::removeAccelMark(m_pTabWidgetSystem->tabText(2));
+        /* VT-x/AMD-V capability test: */
+        if (!vboxGlobal().host().GetProcessorFeature(KProcessorFeature_HWVirtEx) && m_pCheckBoxVirtualization->isChecked())
+        {
+            message.second << tr(
+                "The hardware virtualization is enabled in the Acceleration section of the System page although "
+                "it is not supported by the host system. It should be disabled in order to start the virtual system");
+
+            fPass = false;
+        }
+        /* Serialize message: */
+        if (!message.second.isEmpty())
+            messages << message;
+
+    }
     /* Return result: */
     return fPass;
@@ -582 +600 @@
 
     /* Polish 'Acceleration' availability: */
-    setAccelerationCheckBoxesEnabled(systemData.m_fSupportedHwVirtEx && isMachineOffline());
+    /* Enable the hardware virtulization related check boxes if it is supported by the host system or
+       it is enabled in the vm (in this case check box is enabled so that user can deselect the checkbox
+       and disable the hardware virtualization (see #9184 for the discussion) */
+    setAccelerationCheckBoxesEnabled((systemData.m_fSupportedHwVirtEx && isMachineOffline()) ||
+                                     (systemData.m_fEnabledHwVirtEx && isMachineOffline()));
     m_pLabelParavirtProvider->setEnabled(isMachineOffline());
     m_pComboParavirtProvider->setEnabled(isMachineOffline());