Changeset 72914 in vbox

Timestamp:

Jul 5, 2018 10:57:52 AM (6 years ago)

Author:

vboxsync

Message:

Debugger: Properly print the end of IRB/IOPB range in TSS. Also fixed display for ports not covered by IOPB.

File:

• trunk/src/VBox/Debugger/DBGCEmulateCodeView.cpp (modified) (4 diffs)

trunk/src/VBox/Debugger/DBGCEmulateCodeView.cpp

@@ -4466 +4466 @@
                     }
                 }
-                if (iStart != 255)
-                    DBGCCmdHlpPrintf(pCmdHlp, "%02x-%02x %s\n", iStart, 255, fPrev ? "Protected mode" : "Redirected");
+                DBGCCmdHlpPrintf(pCmdHlp, "%02x-%02x %s\n", iStart, 255, fPrev ? "Protected mode" : "Redirected");
             }
             else
@@ -4480 +4479 @@
 
     /*
-     * Dump the I/O permission bitmap if present. The IOPM cannot start below offset 0x64
+     * Dump the I/O permission bitmap if present. The IOPM cannot start below offset 0x68
      * (that applies to both 32-bit and 64-bit TSSs since their size is the same).
+     * Note that there is always one padding byte that is not technically part of the bitmap
+     * and "must have all bits set". It's not clear what happens when it doesn't. All ports
+     * not covered by the bitmap are considered to be not accessible.
      */
     if (enmTssType != kTss16)
     {
-        if (offIoBitmap < cbTss && offIoBitmap >= 0x64)
+        if (offIoBitmap < cbTss && offIoBitmap >= 0x68)
         {
             uint32_t        cPorts      = RT_MIN((cbTss - offIoBitmap) * 8, _64K);
@@ -4496 +4498 @@
             bool            fPrev       = ASMBitTest(pbIoBitmap, 0);
             uint32_t        cLine       = 0;
-            for (uint32_t i = 1; i < cPorts; i++)
+            for (uint32_t i = 1; i < _64K; i++)
             {
-                bool fThis = ASMBitTest(pbIoBitmap, i);
+                bool fThis = i < cPorts ? ASMBitTest(pbIoBitmap, i) : true;
                 if (fThis != fPrev)
                 {
@@ -4508 +4510 @@
                 }
             }
-            if (iStart != _64K-1)
-                DBGCCmdHlpPrintf(pCmdHlp, "%04x-%04x %s\n", iStart, _64K-1, fPrev ? "GP" : "OK");
+            DBGCCmdHlpPrintf(pCmdHlp, "%04x-%04x %s\n", iStart, _64K-1, fPrev ? "GP" : "OK");
         }
         else if (offIoBitmap > 0)