Changeset 72944 in vbox for trunk/src/VBox/Main/glue

Timestamp:

Jul 7, 2018 3:27:11 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

123496

Message:

GluePrintErrorContext: In fact, don't make any copy of anything here. RTMsgError does an excellent job deal without out-of-memory and similar mishaps, Utf8Str doesn't.

File:

• trunk/src/VBox/Main/glue/errorprint.cpp (modified) (1 diff)

trunk/src/VBox/Main/glue/errorprint.cpp

@@ -84 +84 @@
     // pcszSourceFile comes from __FILE__ macro, which always contains the full path,
     // which we don't want to see printed:
-    Utf8Str str = Utf8StrFmt("Context: \"%s\" at line %d of file %s\n",
-                             pcszContext,
-                             ulLine,
-                             RTPathFilename(pcszSourceFile));
     // print and log
-    RTMsgError("%s", str.c_str());
-    Log(("%s", str.c_str()));
+    const char *pszFilenameOnly = RTPathFilename(pcszSourceFile);
+    RTMsgError("Context: \"%s\" at line %d of file %s\n", pcszContext, ulLine, pszFilenameOnly);
+    Log(("Context: \"%s\" at line %d of file %s\n", pcszContext, ulLine, pszFilenameOnly));
 }