Changeset 73071 in vbox for trunk/src/libs/xpcom18a4/nsprpub

Timestamp:

Jul 11, 2018 4:02:23 PM (6 years ago)

Author:

vboxsync

Message:

xpcom: fix thinko in PR_LogPrint. Harmless in practice since the bug
affected only XP_MAC (i.e. ancient MacOS, not OS X).

File:

• trunk/src/libs/xpcom18a4/nsprpub/pr/src/io/prlog.c (modified) (1 diff)

trunk/src/libs/xpcom18a4/nsprpub/pr/src/io/prlog.c

@@ -527 +527 @@
 
     nb += PR_vsnprintf(line+nb, sizeof(line)-nb-1, fmt, ap);
-    if (nb && (line[nb-1] != '\n')) {
+    if (nb > 0) {
+        if (line[nb-1] != '\n') {
 #ifndef XP_MAC
-        line[nb++] = '\n';
-#else
-        line[nb++] = '\015';
-#endif
-        line[nb] = '\0';
-    } else {
+            line[nb++] = '\n';
+#else
+            line[nb++] = '\015';
+#endif
+            line[nb] = '\0';
+        } else {
 #ifdef XP_MAC
-        line[nb-1] = '\015';
-#endif
+            line[nb-1] = '\015';
+#endif
+        }
     }
     va_end(ap);