Changeset 7314 in vbox

Timestamp:

Mar 6, 2008 10:11:22 AM (17 years ago)

Author:

vboxsync

Message:

pcnet: cosmetics

File:

• trunk/src/VBox/Devices/Network/DevPCNet.cpp (modified) (8 diffs)

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -603 +603 @@
     uint8_t    ownbyte;
 
-    if (!BCR_SWSTYLE(pData))
+    if (RT_UNLIKELY(BCR_SWSTYLE(pData) == 0))
     {
         uint16_t xda[4];
@@ -646 +646 @@
     STAM_PROFILE_ADV_START(&pData->CTXSUFF(StatTmdStore), a);
     PPDMDEVINS pDevIns = PCNETSTATE_2_DEVINS(pData);
-    if (!BCR_SWSTYLE(pData))
+    if (RT_UNLIKELY(BCR_SWSTYLE(pData) == 0))
     {
         uint16_t xda[4];
@@ -689 +689 @@
     uint8_t    ownbyte;
 
-    if (!BCR_SWSTYLE(pData))
+    if (RT_UNLIKELY(BCR_SWSTYLE(pData) == 0))
     {
         uint16_t rda[4];
@@ -730 +730 @@
 {
     PPDMDEVINS pDevIns = PCNETSTATE_2_DEVINS(pData);
-    if (!BCR_SWSTYLE(pData))
+    if (RT_UNLIKELY(BCR_SWSTYLE(pData) == 0))
     {
         uint16_t rda[4];
@@ -1884 +1884 @@
     Assert(cbFrame < sizeof(pData->abSendBuf));
 
-    PDMDevHlpPhysRead(pData->CTXSUFF(pDevIns), GCPhysFrame,
-                      &pData->abSendBuf[0],
-                      cbFrame);
+    PDMDevHlpPhysRead(pData->CTXSUFF(pDevIns), GCPhysFrame, &pData->abSendBuf[0], cbFrame);
     pData->SendFrame.pvBuf = pData->abSendBuf;
     pData->SendFrame.cb    = cbFrame;
@@ -1898 +1896 @@
 {
     Assert(pData->SendFrame.cb + cbFrame < sizeof(pData->abSendBuf));
-    PDMDevHlpPhysRead(pData->CTXSUFF(pDevIns), GCPhysFrame,
-                      &pData->abSendBuf[pData->SendFrame.cb],
-                      cbFrame);
+    PDMDevHlpPhysRead(pData->CTXSUFF(pDevIns), GCPhysFrame, &pData->abSendBuf[pData->SendFrame.cb], cbFrame);
     pData->SendFrame.cb += cbFrame;
 }
@@ -4638 +4634 @@
 
     unsigned i;
+    NOREF(i);
+
 #ifdef PCNET_QUEUE_SEND_PACKETS
     pData->ulXmitRingBufProd   = 0;
@@ -4643 +4641 @@
     pData->pXmitRingBuffer[0]  = (char *)RTMemAlloc(PCNET_MAX_XMIT_SLOTS * 1536);
     pData->cbXmitRingBuffer[0] = 0;
-    for (i=1;i<PCNET_MAX_XMIT_SLOTS;i++)
+    for (i = 1; i < PCNET_MAX_XMIT_SLOTS; i++)
     {
         pData->pXmitRingBuffer[i]  = pData->pXmitRingBuffer[i-1] + 1536;