Changeset 73253 in vbox

Timestamp:

Jul 19, 2018 8:01:45 PM (7 years ago)

Author:

vboxsync

Message:

PGM,HM: Added todos about cleaning up the nested packing hacks. (bugref:9044)

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/PGMAll.cpp (modified) (1 diff)
• VMMR0/HMSVMR0.cpp (modified) (1 diff)
• VMMR0/PGMR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAll.cpp

@@ -1822 +1822 @@
     PGM_LOCK_ASSERT_OWNER(pVCpu->CTX_SUFF(pVM));
 
+/** @todo r=bird: Gotta love this nested paging hacking we're still carrying with us... (Split PGM_TYPE_NESTED.) */
     int rc;
     switch (enmShwPagingMode)

trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp

@@ -7200 +7200 @@
      * Determine the nested paging mode.
      */
+/** @todo r=bird: Gotta love this nested paging hacking we're still carrying with us... (Split PGM_TYPE_NESTED.) */
     PGMMODE enmNestedPagingMode;
 #if HC_ARCH_BITS == 32

trunk/src/VBox/VMM/VMMR0/PGMR0.cpp

@@ -37 +37 @@
  * Instantiate the ring-0 header/code templates.
  */
+/** @todo r=bird: Gotta love this nested paging hacking we're still carrying with us... (Split PGM_TYPE_NESTED.) */
 #define PGM_BTH_NAME(name)          PGM_BTH_NAME_32BIT_PROT(name)
 #include "PGMR0Bth.h"
@@ -509 +510 @@
      *       can use existing code to build the nested page tables.
      */
+/** @todo r=bird: Gotta love this nested paging hacking we're still carrying with us... (Split PGM_TYPE_NESTED.) */
     bool fLockTaken = false;
     switch (enmShwPagingMode)