Changeset 73275 in vbox for trunk/src/VBox/VMM

Timestamp:

Jul 20, 2018 4:02:44 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

123882

Message:

PGM: Trying to figure out VERR_PGM_POOL_FLUSHED... bugref:9044

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• PGMAllBth.h (modified) (2 diffs)
• PGMAllPool.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -142 +142 @@
                           NIL_PGMPOOL_IDX, UINT32_MAX, false /*fLockPage*/,
                           &pNewShwPageCR3);
-    if (rc == VERR_PGM_POOL_FLUSHED)
+    if (rc == VERR_PGM_POOL_FLUSHED) /** @todo r=bird: VERR_PGM_POOL_FLUSHED won't be returned */
     {
         Log(("Bth-Enter: PGM pool flushed -> signal sync cr3\n"));
@@ -2952 +2952 @@
             return VINF_SUCCESS;
         }
-        else if (rc == VERR_PGM_POOL_FLUSHED)
+        else if (rc == VERR_PGM_POOL_FLUSHED) /** @todo r=bird: VERR_PGM_POOL_FLUSHED won't be returned */
         {
             VMCPU_FF_SET(pVCpu, VMCPU_FF_PGM_SYNC_CR3);

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -2920 +2920 @@
  * @returns VBox status code.
  * @retval  VINF_SUCCESS if successfully added.
- * @retval  VERR_PGM_POOL_FLUSHED if the pool was flushed.
+ * @retval  <del>VERR_PGM_POOL_FLUSHED</del> if the pool was flushed - this is
+ *          not returned anywhere anymore.
  * @param   pPool       The pool.
  * @param   iUser       The user index.
@@ -2950 +2951 @@
  * @returns VBox status code.
  * @retval  VINF_SUCCESS if successfully added.
- * @retval  VERR_PGM_POOL_FLUSHED if the pool was flushed.
+ * @retval  <del>VERR_PGM_POOL_FLUSHED</del> if the pool was flushed - this is
+ *          not returned anywhere anymore.
+ *
  * @param   pPool       The pool.
  * @param   pPage       The cached page.
@@ -3038 +3041 @@
  * @returns VBox status code.
  * @retval  VINF_SUCCESS if successfully added.
- * @retval  VERR_PGM_POOL_FLUSHED if the pool was flushed.
+ * @retval  <del>VERR_PGM_POOL_FLUSHED</del> if the pool was flushed - this is
+ *          not returned anywhere anymore.
+ *
  * @param   pPool       The pool.
  * @param   pPage       The cached page.
@@ -5099 +5104 @@
  * @returns VBox status code.
  * @retval  VINF_SUCCESS on success.
- * @retval  VERR_PGM_POOL_FLUSHED if the pool was flushed.
+ * @retval  <del>VERR_PGM_POOL_FLUSHED</del> if the pool was flushed - this is
+ *          not returned anywhere anymore.
  *
  * @param   pPool       The pool.
@@ -5151 +5157 @@
  * @retval  VINF_SUCCESS if a NEW page was allocated.
  * @retval  VINF_PGM_CACHED_PAGE if a CACHED page was returned.
- * @retval  VERR_PGM_POOL_FLUSHED if the pool was flushed.
+ * @retval  <del>VERR_PGM_POOL_FLUSHED</del> if the pool was flushed - this is
+ *          not returned anywhere anymore.
  *
  * @param   pVM         The cross context VM structure.