Changeset 73285 in vbox for trunk/include/VBox

Timestamp:

Jul 21, 2018 1:49:30 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

123892

Message:

APIC,PDM: Avoid a few more return-to-ring-3 statuses now that we've got LogRel. Updated related (mostly) docs here and there. bugref:9044

File:

• trunk/include/VBox/vmm/pdmdev.h (modified) (3 diffs)

trunk/include/VBox/vmm/pdmdev.h

@@ -1209 +1209 @@
      * @param   iLevel          IRQ level. See the PDM_IRQ_LEVEL_* \#defines.
      * @param   uTagSrc         The IRQ tag and source (for tracing).
+     *
      * @remarks Caller enters the PDM critical section
+     *          Actually, as per 2018-07-21 this isn't true (bird).
      */
     DECLR3CALLBACKMEMBER(void, pfnSetIrqR3,(PPDMDEVINS pDevIns, int iIrq, int iLevel, uint32_t uTagSrc));
@@ -1226 +1228 @@
      * @param   uValue          Request value.
      * @param   uTagSrc         The IRQ tag and source (for tracing).
+     *
      * @remarks Caller enters the PDM critical section
+     *          Actually, as per 2018-07-21 this isn't true (bird).
      */
     DECLR3CALLBACKMEMBER(void, pfnSendMsiR3,(PPDMDEVINS pDevIns, RTGCPHYS GCPhys, uint32_t uValue, uint32_t uTagSrc));
@@ -1239 +1243 @@
      * Set the EOI for an interrupt vector.
      *
-     * @returns VBox status code.
+     * @returns Strict VBox status code - only the following informational status codes:
+     * @retval  VINF_IOM_R3_MMIO_WRITE if the I/O APIC lock is contenteded and we're in R0 or RC.2
+     * @retval  VINF_SUCCESS
+     *
      * @param   pDevIns         Device instance of the I/O APIC.
      * @param   u8Vector        The vector.
+     *
      * @remarks Caller enters the PDM critical section
+     *          Actually, as per 2018-07-21 this isn't true (bird).
      */
     DECLR3CALLBACKMEMBER(int, pfnSetEoiR3,(PPDMDEVINS pDevIns, uint8_t u8Vector));