Changeset 73413 in vbox for trunk/src/VBox

Timestamp:

Jul 31, 2018 4:58:20 PM (6 years ago)

Author:

vboxsync

Message:

DBGPlugInWinNt.cpp: Must unlink all our modules during termination of we risk crashing when the private loader reader instance is closed, due to our plugin being unloaded.

File:

• trunk/src/VBox/Debugger/DBGPlugInWinNt.cpp (modified) (2 diffs)

trunk/src/VBox/Debugger/DBGPlugInWinNt.cpp

@@ -798 +798 @@
     Assert(pThis->fValid);
 
-    pThis->fValid = false;
-}
-
-
-/**
- * @copydoc DBGFOSREG::pfnRefresh
- */
-static DECLCALLBACK(int)  dbgDiggerWinNtRefresh(PUVM pUVM, void *pvData)
-{
-    PDBGDIGGERWINNT pThis = (PDBGDIGGERWINNT)pvData;
-    NOREF(pThis);
-    Assert(pThis->fValid);
-
     /*
-     * For now we'll flush and reload everything.
+     * As long as we're using our private LDR reader implementation,
+     * we must unlink and ditch the modules we created.
      */
     RTDBGAS hDbgAs = DBGFR3AsResolveAndRetain(pUVM, DBGF_AS_KERNEL);
@@ -834 +822 @@
     }
 
+    pThis->fValid = false;
+}
+
+
+/**
+ * @copydoc DBGFOSREG::pfnRefresh
+ */
+static DECLCALLBACK(int)  dbgDiggerWinNtRefresh(PUVM pUVM, void *pvData)
+{
+    PDBGDIGGERWINNT pThis = (PDBGDIGGERWINNT)pvData;
+    NOREF(pThis);
+    Assert(pThis->fValid);
+
+    /*
+     * For now we'll flush and reload everything.
+     */
     dbgDiggerWinNtTerm(pUVM, pvData);
+
     return dbgDiggerWinNtInit(pUVM, pvData);
 }