Changeset 73469 in vbox for trunk/src/VBox/Frontends

Timestamp:

Aug 3, 2018 12:04:15 PM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: Made UIMainEventListeningThread::~UIMainEventListeningThread() more debugger friendly and added a todo about not deleting the thread object for threads that are still running.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMainEventListener.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMainEventListener.cpp

@@ -116 +116 @@
     , m_fShutdown(false)
 {
+    setObjectName("UIMainEventListeningThread");
 }
 
@@ -123 +124 @@
     setShutdown(true);
 
-    /* And wait 30 seconds for run() to finish: */
-    wait(30000);
+    /* And wait 30 seconds for run() to finish (1 sec increments to help with
+       delays incurred debugging and prevent suicidal use-after-free behaviour): */
+    uint32_t i = 30000;
+    do
+        wait(1000);
+    while (i-- > 0 && !isFinished());
 }
 
@@ -204 +209 @@
 {
     /* Wipe out the threads: */
+    /** @todo r=bird: The use of qDeleteAll here is unsafe because it won't take
+     * QThread::wait() timeouts into account, and may delete the QThread object
+     * while the thread is still running, causing heap corruption/crashes once
+     * the thread awakens and gets on with its termination.
+     * Observed with debugger + paged heap.
+     *
+     * Should use specialized thread list which only deletes the threads after
+     * isFinished() returns true, leaving them alone on timeout failures. */
     qDeleteAll(m_threads);
 }