Changeset 7358 in vbox

Timestamp:

Mar 7, 2008 1:13:17 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

28781

Message:

pcnet: logging

File:

• trunk/src/VBox/Devices/Network/DevPCNet.cpp (modified) (93 diffs)

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -71 +71 @@
 #define PCNET_GC_ENABLED
 
-#if 0
-#define LOG_REGISTER(a)                 LogRel(a)
-#else
-#define LOG_REGISTER(a)
-#endif
-#if 0
-#define LOG_PACKET(name, buf, count)    LogPkt(name, buf, count)
-#define LOG_PACKETS
-#else
-#define LOG_PACKET(name, buf, count)
-#undef  LOG_PACKETS
-#endif
-
 #if defined(LOG_ENABLED)
 #define PCNET_DEBUG_IO
@@ -105 +92 @@
 /* Maximum number of times we report a link down to the guest (failure to send frame) */
 #define PCNET_MAX_LINKDOWN_REPORTED     3
+
+#define MAX_FRAME                       1536
 
 /* Frame cache */
@@ -250 +239 @@
     uint32_t                            u32LinkSpeed;
 
-/* #define PCNET_QUEUE_SEND_PACKETS */
+//#define PCNET_QUEUE_SEND_PACKETS
 #ifdef PCNET_QUEUE_SEND_PACKETS
     #define PCNET_MAX_XMIT_SLOTS         128
@@ -263 +252 @@
     STAMCOUNTER                         StatReceiveBytes;
     STAMCOUNTER                         StatTransmitBytes;
-
 #ifdef VBOX_WITH_STATISTICS
     STAMPROFILEADV                      StatMMIOReadGC;
@@ -309 +297 @@
 };
 
-#define PCNETSTATE_2_DEVINS(pPCNet)            ( (pPCNet)->CTXSUFF(pDevIns) )
-#define PCIDEV_2_PCNETSTATE(pPciDev)           ( (PCNetState *)(pPciDev) )
+#define PCNETSTATE_2_DEVINS(pPCNet)            ((pPCNet)->CTXSUFF(pDevIns))
+#define PCIDEV_2_PCNETSTATE(pPciDev)           ((PCNetState *)(pPciDev))
+#define PCNET_INST_NR                          (PCNETSTATE_2_DEVINS(pData)->iInstance)
 
 /* BUS CONFIGURATION REGISTERS */
@@ -812 +801 @@
 };
 #pragma pack()
-
-#ifdef LOG_PACKETS
-static void LogPkt(const char *name, const void *const src, int count)
-{
-    int i, j;
-    const uint8_t * const p = (const uint8_t * const)src;
-    LogRel(("%s:  ", name));
-    i  = 14;               // length of MAC header
-    i += 4*(p[i] & 15);    // length of IP  header
-    i += 4*(p[i+12] >> 4); // length of TCP header
-    for (j=i; j<70 && j<count; j++)
-        LogRel((" %02x", p[j]));
-    LogRel((" ("));
-    for (j=i; j<70 && j<count; j++)
-        LogRel(("%c", p[j] >= 32 && p[j] < 127 ? p[j] : '.'));
-    LogRel((")\n"));
-}
-#endif
 
 #define PRINT_PKTHDR(BUF) do {                                        \
@@ -961 +932 @@
 #ifdef PCNET_DEBUG_MATCH
     Log(("#%d packet dhost=%02x:%02x:%02x:%02x:%02x:%02x, "
-         "padr=%02x:%02x:%02x:%02x:%02x:%02x\n",
-         PCNETSTATE_2_DEVINS(pData)->iInstance,
+         "padr=%02x:%02x:%02x:%02x:%02x:%02x => %d\n", PCNET_INST_NR,
          hdr->ether_dhost[0],hdr->ether_dhost[1],hdr->ether_dhost[2],
          hdr->ether_dhost[3],hdr->ether_dhost[4],hdr->ether_dhost[5],
-         padr[0],padr[1],padr[2],padr[3],padr[4],padr[5]));
-    Log(("padr_match result=%d\n", result));
+         padr[0],padr[1],padr[2],padr[3],padr[4],padr[5], result));
 #endif
     return result;
@@ -977 +946 @@
     int result = !CSR_DRCVBC(pData) && !memcmp(hdr->ether_dhost, aBCAST, 6);
 #ifdef PCNET_DEBUG_MATCH
-    Log(("#%d padr_bcast result=%d\n", PCNETSTATE_2_DEVINS(pData)->iInstance, result));
+    Log(("#%d padr_bcast result=%d\n", PCNET_INST_NR, result));
 #endif
    return result;
@@ -1076 +1045 @@
     PCNetState *pData   = (PCNetState *)pvUser;
 
-    Log(("#%d pcnetHandleRingWriteGC: write to %#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance, GCPhysFault));
+    Log(("#%d pcnetHandleRingWriteGC: write to %#010x\n", PCNET_INST_NR, GCPhysFault));
 
     uint32_t cb;
@@ -1137 +1106 @@
     PCNetState *pData   = PDMINS2DATA(pDevIns, PCNetState *);
 
-    Log(("#%d pcnetHandleRingWrite: write to %#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance, GCPhys));
+    Log(("#%d pcnetHandleRingWrite: write to %#010x\n", PCNET_INST_NR, GCPhys));
 #ifdef VBOX_WITH_STATISTICS
     STAM_COUNTER_INC(&CTXSUFF(pData->StatRingWrite));
@@ -1172 +1141 @@
 static void pcnetSoftReset(PCNetState *pData)
 {
-    Log(("#%d pcnetSoftReset:\n", PCNETSTATE_2_DEVINS(pData)->iInstance));
+    Log(("#%d pcnetSoftReset:\n", PCNET_INST_NR));
 
     pData->u32Lnkst = 0x40;
@@ -1257 +1226 @@
         pData->aCSR[4] &= ~0x0080; /* clear UINTCMD */
         pData->aCSR[4] |=  0x0040; /* set UINT */
-        Log(("#%d user int\n", PCNETSTATE_2_DEVINS(pData)->iInstance));
+        Log(("#%d user int\n", PCNET_INST_NR));
     }
     if (pData->aCSR[4] & csr0 & 0x0040 /* CSR_INEA */)
@@ -1271 +1240 @@
         csr0           |=  0x0080; /* set INTR */
         iISR = 1;
-        Log(("#%d user int\n", PCNETSTATE_2_DEVINS(pData)->iInstance));
+        Log(("#%d user int\n", PCNET_INST_NR));
     }
 #endif /* !VBOX */
@@ -1291 +1260 @@
     pData->aCSR[0] = csr0;
 
-    Log2(("#%d set irq iISR=%d\n", PCNETSTATE_2_DEVINS(pData)->iInstance, iISR));
+    Log2(("#%d set irq iISR=%d\n", PCNET_INST_NR, iISR));
 
     /* normal path is to _not_ change the IRQ status */
     if (RT_UNLIKELY(iISR != pData->iISR))
     {
-        Log(("#%d INTA=%d\n", PCNETSTATE_2_DEVINS(pData)->iInstance, iISR));
+        Log(("#%d INTA=%d\n", PCNET_INST_NR, iISR));
         PDMDevHlpPCISetIrqNoWait(PCNETSTATE_2_DEVINS(pData), 0, iISR);
         pData->iISR = iISR;
@@ -1396 +1365 @@
 {
     PPDMDEVINS pDevIns = PCNETSTATE_2_DEVINS(pData);
-    Log(("#%d pcnetInit: init_addr=%#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
-         PHYSADDR(pData, CSR_IADR(pData))));
+    Log(("#%d pcnetInit: init_addr=%#010x\n", PCNET_INST_NR, PHYSADDR(pData, CSR_IADR(pData))));
 
     /** @todo Documentation says that RCVRL and XMTRL are stored as two's complement!
@@ -1425 +1393 @@
         PCNET_INIT();
         Log(("#%d initblk.rlen=%#04x, initblk.tlen=%#04x\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, initblk.rlen, initblk.tlen));
+             PCNET_INST_NR, initblk.rlen, initblk.tlen));
     }
     else
@@ -1433 +1401 @@
         PCNET_INIT();
         Log(("#%d initblk.rlen=%#04x, initblk.tlen=%#04x\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, initblk.rlen, initblk.tlen));
+             PCNET_INST_NR, initblk.rlen, initblk.tlen));
     }
 
@@ -1453 +1421 @@
 
     LogRel(("PCNet#%d: Init: ss32=%d GCRDRA=%#010x[%d] GCTDRA=%#010x[%d]\n",
-            PCNETSTATE_2_DEVINS(pData)->iInstance, BCR_SSIZE32(pData),
+            PCNET_INST_NR, BCR_SSIZE32(pData),
             pData->GCRDRA, CSR_RCVRL(pData), pData->GCTDRA, CSR_XMTRL(pData)));
 
@@ -1466 +1434 @@
 static void pcnetStart(PCNetState *pData)
 {
-    Log(("#%d pcnetStart:\n", PCNETSTATE_2_DEVINS(pData)->iInstance));
+    Log(("#%d pcnetStart:\n", PCNET_INST_NR));
     if (!CSR_DTX(pData))
         pData->aCSR[0] |= 0x0010;    /* set TXON */
@@ -1480 +1448 @@
 static void pcnetStop(PCNetState *pData)
 {
-    Log(("#%d pcnetStop:\n", PCNETSTATE_2_DEVINS(pData)->iInstance));
+    Log(("#%d pcnetStop:\n", PCNET_INST_NR));
     pData->aCSR[0] &= ~0x7feb;
     pData->aCSR[0] |=  0x0014;
@@ -1553 +1521 @@
                 /* This is not problematic since we don't own the descriptor */
                 LogRel(("PCNet#%d: BAD RMD ENTRIES AT %#010x (i=%d)\n",
-                        PCNETSTATE_2_DEVINS(pData)->iInstance, addr, i));
+                        PCNET_INST_NR, addr, i));
                 return;
             }
@@ -1583 +1551 @@
             /* This is not problematic since we don't own the descriptor */
             LogRel(("PCNet#%d: BAD RMD ENTRIES + AT %#010x (i=%d)\n",
-                    PCNETSTATE_2_DEVINS(pData)->iInstance, addr, i));
+                    PCNET_INST_NR, addr, i));
             return;
         }
@@ -1620 +1588 @@
             STAM_PROFILE_ADV_STOP(&pData->CTXSUFF(StatTdtePoll), a);
             LogRel(("PCNet#%d: BAD TMD XDA=%#010x\n",
-                    PCNETSTATE_2_DEVINS(pData)->iInstance, PHYSADDR(pData, cxda)));
+                    PCNET_INST_NR, PHYSADDR(pData, cxda)));
             return 0;
         }
@@ -1668 +1636 @@
 
     /* byte count stored in two's complement 12 bits wide */
-    Log(("#%d pcnetCanReceiveNoSync %d bytes\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log(("#%d pcnetCanReceiveNoSync %d bytes\n", PCNET_INST_NR,
          4096 - CSR_CRBC(pData)));
     return 4096 - CSR_CRBC(pData);
@@ -1686 +1654 @@
         return;
 
-    Log(("#%d pcnetReceiveNoSync: size=%d\n", PCNETSTATE_2_DEVINS(pData)->iInstance, size));
-
-    LOG_PACKET("rraw", buf, size);
+    Log(("#%d pcnetReceiveNoSync: size=%d\n", PCNET_INST_NR, size));
 
     /*
@@ -1705 +1671 @@
              * we already called pcnetCanReceive(). */
             LogRel(("PCNet#%d: no buffer: RCVRC=%d\n",
-                    PCNETSTATE_2_DEVINS(pData)->iInstance, CSR_RCVRC(pData)));
+                    PCNET_INST_NR, CSR_RCVRC(pData)));
             /* Dump the status of all RX descriptors */
             const unsigned  cb = 1 << pData->iLog2DescSize;
@@ -1803 +1769 @@
             {
                 LogRel(("PCNet#%d: Overflow by %ubytes\n",
-                         PCNETSTATE_2_DEVINS(pData)->iInstance, size));
+                         PCNET_INST_NR, size));
                 rmd.rmd1.oflo = 1;
                 rmd.rmd1.buff = 1;
@@ -1814 +1780 @@
             pData->aCSR[0] |= 0x0400;
 
-            Log(("#%d RCVRC=%d CRDA=%#010x BLKS=%d\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+            Log(("#%d RCVRC=%d CRDA=%#010x BLKS=%d\n", PCNET_INST_NR,
                  CSR_RCVRC(pData), PHYSADDR(pData, CSR_CRDA(pData)), pktcount));
 #ifdef PCNET_DEBUG_RMD
@@ -1952 +1918 @@
     STAM_PROFILE_ADV_STOP(&pData->StatTransmitSend, a);
 
-    return PDMCritSectEnter(&pData->CritSect, VERR_PERMISSION_DENIED);
+    return PDMCritSectEnter(&pData->CritSect, VERR_SEM_BUSY);
 #endif
 }
@@ -1968 +1934 @@
     pData->Led.Asserted.s.fError = pData->Led.Actual.s.fError = 1;
     Log(("#%d pcnetTransmit: Signaling send error. swstyle=%#x\n",
-         PCNETSTATE_2_DEVINS(pData)->iInstance, pData->aBCR[BCR_SWS]));
+         PCNET_INST_NR, pData->aBCR[BCR_SWS]));
 }
 
@@ -1981 +1947 @@
     pData->Led.Asserted.s.fError = pData->Led.Actual.s.fError = 1;
     Log(("#%d pcnetTransmit: Signaling send error. swstyle=%#x\n",
-         PCNETSTATE_2_DEVINS(pData)->iInstance, pData->aBCR[BCR_SWS]));
+         PCNET_INST_NR, pData->aBCR[BCR_SWS]));
 }
 
@@ -2081 +2047 @@
         STAM_PROFILE_ADV_STOP(&pData->StatTransmitSend, a);
 
-        PDMCritSectEnter(&pData->CritSect, VERR_PERMISSION_DENIED);
+        PDMCritSectEnter(&pData->CritSect, VERR_SEM_BUSY);
 
         pData->cbXmitRingBuffer[pData->ulXmitRingBufCons] = 0;
@@ -2124 +2090 @@
 
 #ifdef PCNET_DEBUG_TMD
-        Log2(("#%d TMDLOAD %#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance, PHYSADDR(pData, CSR_CXDA(pData))));
+        Log2(("#%d TMDLOAD %#010x\n", PCNET_INST_NR, PHYSADDR(pData, CSR_CXDA(pData))));
         PRINT_TMD(&tmd);
 #endif
@@ -2135 +2101 @@
         {
             const unsigned cb = 4096 - tmd.tmd1.bcnt;
-            Log(("#%d pcnetTransmit: stp&enp: cb=%d xmtrc=%#x\n", PCNETSTATE_2_DEVINS(pData)->iInstance, cb, CSR_XMTRC(pData)));
+            Log(("#%d pcnetTransmit: stp&enp: cb=%d xmtrc=%#x\n", PCNET_INST_NR, cb, CSR_XMTRC(pData)));
 
             if (RT_LIKELY(pcnetIsLinkUp(pData) || CSR_LOOP(pData)))
@@ -2143 +2109 @@
                  * ENP = 1).'' That means that the first buffer might have a
                  * zero length if it is not the last one in the chain. */
-                if (RT_LIKELY(cb <= 1536))
+                if (RT_LIKELY(cb <= MAX_FRAME))
                 {
                     pcnetXmitRead1st(pData, PHYSADDR(pData, tmd.tmd0.tbadr), cb);
@@ -2167 +2133 @@
                      * the buffer length of 0 is interpreted as a 4096-byte
                      * buffer.'' */
-                    LogRel(("PCNET: pcnetAsyncTransmit: illegal 4kb frame -> ignoring\n"));
+                    LogRel(("PCNet#%d: pcnetAsyncTransmit: illegal 4kb frame -> ignoring\n", PCNET_INST_NR));
                     pcnetTmdStorePassHost(pData, &tmd, PHYSADDR(pData, CSR_CXDA(pData)));
                     break;
@@ -2175 +2141 @@
                     /* Signal error, as this violates the Ethernet specs. */
                     /** @todo check if the correct error is generated. */
-                    LogRel(("PCNET: pcnetAsyncTransmit: illegal 4kb frame -> signalling error\n"));
+                    LogRel(("PCNet#%d: pcnetAsyncTransmit: illegal 4kb frame -> signalling error\n", PCNET_INST_NR));
 
                     pcnetXmitFailTMDGeneric(pData, &tmd);
@@ -2197 +2163 @@
              * Read TMDs until end-of-packet or tdte poll fails (underflow).
              */
-            const unsigned cbMaxFrame = 1536;
             bool fDropFrame = false;
             unsigned cb = 4096 - tmd.tmd1.bcnt;
@@ -2241 +2206 @@
                 pcnetTmdLoad(pData, &tmd, PHYSADDR(pData, CSR_CXDA(pData)), false);
                 cb = 4096 - tmd.tmd1.bcnt;
-                if (    pData->SendFrame.cb + cb < cbMaxFrame
+                if (    pData->SendFrame.cb + cb < MAX_FRAME
                     &&  !fDropFrame)
                     pcnetXmitReadMore(pData, PHYSADDR(pData, tmd.tmd0.tbadr), cb);
@@ -2252 +2217 @@
                 if (tmd.tmd1.enp)
                 {
-                    Log(("#%d pcnetTransmit: stp: cb=%d xmtrc=%#x-%#x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+                    Log(("#%d pcnetTransmit: stp: cb=%d xmtrc=%#x-%#x\n", PCNET_INST_NR,
                          pData->SendFrame.cb, iStart, CSR_XMTRC(pData)));
                     if (pcnetIsLinkUp(pData) && !fDropFrame)
@@ -2287 +2252 @@
              */
             /** @todo according to the specs we're supposed to clear the own bit and move on to the next one. */
-            Log(("#%d pcnetTransmit: guest is giving us shit!\n", PCNETSTATE_2_DEVINS(pData)->iInstance));
+            Log(("#%d pcnetTransmit: guest is giving us shit!\n", PCNET_INST_NR));
             break;
         }
@@ -2363 +2328 @@
          * suspended while waiting for the critical section.
          */
-        rc = PDMCritSectEnter(&pThis->CritSect, VERR_PERMISSION_DENIED);
+        rc = PDMCritSectEnter(&pThis->CritSect, VERR_SEM_BUSY);
         AssertReleaseRCReturn(rc, rc);
 
@@ -2421 +2386 @@
     if (CSR_STOP(pData) || CSR_SPND(pData))
         Log2(("#%d pcnetPollTimer time=%#010llx CSR_STOP=%d CSR_SPND=%d\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, RTTimeMilliTS(), CSR_STOP(pData), CSR_SPND(pData)));
+             PCNET_INST_NR, RTTimeMilliTS(), CSR_STOP(pData), CSR_SPND(pData)));
     else
         Log2(("#%d pcnetPollTimer time=%#010llx TDMD=%d TXON=%d POLL=%d TDTE=%d TDRA=%#x\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, RTTimeMilliTS(), CSR_TDMD(pData), CSR_TXON(pData),
+             PCNET_INST_NR, RTTimeMilliTS(), CSR_TDMD(pData), CSR_TXON(pData),
              !CSR_DPOLL(pData), pcnetTdtePoll(pData, &dummy), pData->GCTDRA));
     Log2(("#%d pcnetPollTimer: CSR_CXDA=%#x CSR_XMTRL=%d CSR_XMTRC=%d\n",
-          PCNETSTATE_2_DEVINS(pData)->iInstance, CSR_CXDA(pData), CSR_XMTRL(pData), CSR_XMTRC(pData)));
+          PCNET_INST_NR, CSR_CXDA(pData), CSR_XMTRL(pData), CSR_XMTRC(pData)));
 #endif
 #ifdef PCNET_DEBUG_TMD
@@ -2434 +2399 @@
         TMD tmd;
         pcnetTmdLoad(pData, &tmd, PHYSADDR(pData, CSR_CXDA(pData)), false);
-        Log2(("#%d pcnetPollTimer: TMDLOAD %#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance, PHYSADDR(pData, CSR_CXDA(pData))));
+        Log2(("#%d pcnetPollTimer: TMDLOAD %#010x\n", PCNET_INST_NR, PHYSADDR(pData, CSR_CXDA(pData))));
         PRINT_TMD(&tmd);
     }
@@ -2476 +2441 @@
     int      rc  = VINF_SUCCESS;
 #ifdef PCNET_DEBUG_CSR
-    Log(("#%d pcnetCSRWriteU16: rap=%d val=%#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
+    Log(("#%d pcnetCSRWriteU16: rap=%d val=%#06x\n", PCNET_INST_NR, u32RAP, val));
 #endif
     switch (u32RAP)
@@ -2493 +2458 @@
                     val &= ~3;
 
-                Log(("#%d pcnetWriteCSR0: %#06x => %#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance, pData->aCSR[0], csr0));
+                Log(("#%d pcnetWriteCSR0: %#06x => %#06x\n", PCNET_INST_NR, pData->aCSR[0], csr0));
 
 #ifndef IN_RING3
                 if (!(csr0 & 0x0001/*init*/) && (val & 1))
                 {
-                    Log(("#%d pcnetCSRWriteU16: pcnetInit requested => HC\n", PCNETSTATE_2_DEVINS(pData)->iInstance));
+                    Log(("#%d pcnetCSRWriteU16: pcnetInit requested => HC\n", PCNET_INST_NR));
                     return VINF_IOM_HC_IOPORT_WRITE;
                 }
 #endif
-                LOG_REGISTER(("PCNet#%d: WRITE CSR%d, %#06x => %#06x (%#06x)\n",
-                              PCNETSTATE_2_DEVINS(pData)->iInstance,
-                              u32RAP, new_value, csr0, pData->aCSR[0]));
                 pData->aCSR[0] = csr0;
 
@@ -2563 +2525 @@
             if (CSR_STOP(pData) || CSR_SPND(pData))
                 break;
-            LOG_REGISTER(("PCNet#%d: WRITE CSR%d, %#06x\n",
-                         PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
-            return rc;
         case 3: /* Interrupt Mask and Deferral Control */
-            LOG_REGISTER(("PCNet#%d: WRITE CSR%d, %#06x\n",
-                         PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
             break;
         case 4: /* Test and Features Control */
-            LOG_REGISTER(("PCNet#%d: WRITE CSR%d, %#06x\n",
-                         PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
             pData->aCSR[4] &= ~(val & 0x026a);
             val &= ~0x026a;
@@ -2578 +2533 @@
             break;
         case 5: /* Extended Control and Interrupt 1 */
-            LOG_REGISTER(("PCNet#%d: WRITE CSR%d, %#06x\n",
-                        PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
             pData->aCSR[5] &= ~(val & 0x0a90);
             val &= ~0x0a90;
@@ -2596 +2549 @@
             if ((pData->aCSR[15] & 0x8000) != (val & 0x8000) && pData->pDrv)
             {
-                Log(("PCNet#%d: promiscuous mode changed to %d\n",
-                     PCNETSTATE_2_DEVINS(pData)->iInstance, !!(val & 0x8000)));
+                Log(("#%d: promiscuous mode changed to %d\n", PCNET_INST_NR, !!(val & 0x8000)));
 #ifndef IN_RING3
                 return VINF_IOM_HC_IOPORT_WRITE;
@@ -2620 +2572 @@
             if (!CSR_STOP(pData) && !CSR_SPND(pData))
             {
-                Log(("PCNet#%d: WRITE CSR%d, %#06x !!\n", PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
+                Log(("#%d: WRITE CSR%d, %#06x !!\n", PCNET_INST_NR, u32RAP, val));
                 return rc;
             }
@@ -2627 +2579 @@
             else
                 pData->GCRDRA = (pData->GCRDRA & 0x0000ffff) | ((val & 0x0000ffff) << 16);
-            Log(("PCNet#%d: WRITE CSR%d, %#06x => GCRDRA=%08x (alt init)\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+            Log(("#%d: WRITE CSR%d, %#06x => GCRDRA=%08x (alt init)\n", PCNET_INST_NR,
                  u32RAP, val, pData->GCRDRA));
             break;
@@ -2639 +2591 @@
             if (!CSR_STOP(pData) && !CSR_SPND(pData))
             {
-                Log(("PCNet#%d: WRITE CSR%d, %#06x !!\n", PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
+                Log(("#%d: WRITE CSR%d, %#06x !!\n", PCNET_INST_NR, u32RAP, val));
                 return rc;
             }
@@ -2646 +2598 @@
             else
                 pData->GCTDRA = (pData->GCTDRA & 0x0000ffff) | ((val & 0x0000ffff) << 16);
-            Log(("PCNet#%d: WRITE CSR%d, %#06x => GCTDRA=%08x (alt init)\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+            Log(("#%d: WRITE CSR%d, %#06x => GCTDRA=%08x (alt init)\n", PCNET_INST_NR,
                  u32RAP, val, pData->GCTDRA));
             break;
 
         case 58: /* Software Style */
-            LOG_REGISTER(("PCNet#%d: WRITE SW_STYLE, %#06x\n",
-                         PCNETSTATE_2_DEVINS(pData)->iInstance, val));
             rc = pcnetBCRWriteU16(pData, BCR_SWS, val);
             break;
@@ -2666 +2616 @@
             if (!CSR_STOP(pData) && !CSR_SPND(pData))
             {
-                Log(("PCNet#%d: WRITE CSR%d, %#06x !!\n", PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
+                Log(("#%d: WRITE CSR%d, %#06x !!\n", PCNET_INST_NR, u32RAP, val));
                 return rc;
             }
-            Log(("PCNet#%d: WRITE CSR%d, %#06x (hacked %#06x) (alt init)\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+            Log(("#%d: WRITE CSR%d, %#06x (hacked %#06x) (alt init)\n", PCNET_INST_NR,
                  u32RAP, val, 1 + ~(uint16_t)val));
             val = 1 + ~(uint16_t)val;
@@ -2727 +2677 @@
         default:
             val = pData->aCSR[u32RAP];
-            LOG_REGISTER(("PCNet#%d: read  CSR%d => %#06x\n",
-                    PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
     }
 #ifdef PCNET_DEBUG_CSR
-    Log(("#%d pcnetCSRReadU16: rap=%d val=%#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log(("#%d pcnetCSRReadU16: rap=%d val=%#06x\n", PCNET_INST_NR,
          u32RAP, val));
 #endif
@@ -2742 +2690 @@
     u32RAP &= 0x7f;
 #ifdef PCNET_DEBUG_BCR
-    Log2(("#%d pcnetBCRWriteU16: rap=%d val=%#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetBCRWriteU16: rap=%d val=%#06x\n", PCNET_INST_NR,
          u32RAP, val));
 #endif
@@ -2754 +2702 @@
             {
                 default:
-                    Log(("Bad SWSTYLE=%#04x\n", val & 0xff));
+                    Log(("#%d Bad SWSTYLE=%#04x\n", PCNET_INST_NR, val & 0xff));
                     // fall through
                 case 0:
@@ -2773 +2721 @@
                     break;
             }
-            LOG_REGISTER(("PCNet#%d: WRITE SW_STYLE, %#06x\n",
-                         PCNETSTATE_2_DEVINS(pData)->iInstance, val));
-            Log(("BCR_SWS=%#06x\n", val));
+            Log(("#%d BCR_SWS=%#06x\n", PCNET_INST_NR, val));
             pData->aCSR[58] = val;
             /* fall through */
@@ -2789 +2735 @@
         case BCR_MIICAS:
         case BCR_MIIADDR:
-            LOG_REGISTER(("PCNet#%d: WRITE BCR%d, %#06x\n",
-                         PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
             pData->aBCR[u32RAP] = val;
             break;
@@ -2802 +2746 @@
 
         case BCR_MIIMDR:
-            LOG_REGISTER(("PCNet#%d: WRITE MII%d, %#06x\n",
-                         PCNETSTATE_2_DEVINS(pData)->iInstance, u32RAP, val));
             pData->aMII[pData->aBCR[BCR_MIIADDR] & 0x1f] = val;
 #ifdef PCNET_DEBUG_MII
-            Log(("#%d pcnet: mii write %d <- %#x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+            Log(("#%d pcnet: mii write %d <- %#x\n", PCNET_INST_NR,
                    pData->aBCR[BCR_MIIADDR] & 0x1f, val));
 #endif
@@ -2926 +2868 @@
 
 #ifdef PCNET_DEBUG_MII
-    Log(("#%d pcnet: mii read %d -> %#x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log(("#%d pcnet: mii read %d -> %#x\n", PCNET_INST_NR,
          miiaddr, val));
 #endif
@@ -2968 +2910 @@
     }
 #ifdef PCNET_DEBUG_BCR
-    Log2(("#%d pcnetBCRReadU16: rap=%d val=%#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetBCRReadU16: rap=%d val=%#06x\n", PCNET_INST_NR,
          u32RAP, val));
 #endif
@@ -3020 +2962 @@
     addr &= 0x0f;
     val  &= 0xff;
-    Log(("#%d pcnetAPROMWriteU8: addr=%#010x val=%#04x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log(("#%d pcnetAPROMWriteU8: addr=%#010x val=%#04x\n", PCNET_INST_NR,
          addr, val));
     /* Check APROMWE bit to enable write access */
@@ -3030 +2972 @@
 {
     uint32_t val = pData->aPROM[addr &= 0x0f];
-    Log(("#%d pcnetAPROMReadU8: addr=%#010x val=%#04x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log(("#%d pcnetAPROMReadU8: addr=%#010x val=%#04x\n", PCNET_INST_NR,
          addr, val));
     return val;
@@ -3040 +2982 @@
 
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetIoportWriteU16: addr=%#010x val=%#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetIoportWriteU16: addr=%#010x val=%#06x\n", PCNET_INST_NR,
          addr, val));
 #endif
@@ -3061 +3003 @@
     }
     else
-        Log(("#%d pcnetIoportWriteU16: addr=%#010x val=%#06x BCR_DWIO !!\n", PCNETSTATE_2_DEVINS(pData)->iInstance, addr, val));
+        Log(("#%d pcnetIoportWriteU16: addr=%#010x val=%#06x BCR_DWIO !!\n", PCNET_INST_NR, addr, val));
 
     return rc;
@@ -3099 +3041 @@
     }
     else
-        Log(("#%d pcnetIoportReadU16: addr=%#010x val=%#06x BCR_DWIO !!\n", PCNETSTATE_2_DEVINS(pData)->iInstance, addr, val & 0xffff));
+        Log(("#%d pcnetIoportReadU16: addr=%#010x val=%#06x BCR_DWIO !!\n", PCNET_INST_NR, addr, val & 0xffff));
 
     pcnetUpdateIrq(pData);
@@ -3105 +3047 @@
 skip_update_irq:
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetIoportReadU16: addr=%#010x val=%#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
-         addr, val & 0xffff));
+    Log2(("#%d pcnetIoportReadU16: addr=%#010x val=%#06x\n", PCNET_INST_NR, addr, val & 0xffff));
 #endif
     return val;
@@ -3116 +3057 @@
 
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetIoportWriteU32: addr=%#010x val=%#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetIoportWriteU32: addr=%#010x val=%#010x\n", PCNET_INST_NR,
          addr, val));
 #endif
@@ -3145 +3086 @@
     }
     else
-        Log(("#%d pcnetIoportWriteU32: addr=%#010x val=%#010x !BCR_DWIO !!\n", PCNETSTATE_2_DEVINS(pData)->iInstance, addr, val));
+        Log(("#%d pcnetIoportWriteU32: addr=%#010x val=%#010x !BCR_DWIO !!\n", PCNET_INST_NR, addr, val));
 
     return rc;
@@ -3183 +3124 @@
     }
     else
-        Log(("#%d pcnetIoportReadU32: addr=%#010x val=%#010x !BCR_DWIO !!\n", PCNETSTATE_2_DEVINS(pData)->iInstance, addr, val));
+        Log(("#%d pcnetIoportReadU32: addr=%#010x val=%#010x !BCR_DWIO !!\n", PCNET_INST_NR, addr, val));
     pcnetUpdateIrq(pData);
 
 skip_update_irq:
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetIoportReadU32: addr=%#010x val=%#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetIoportReadU32: addr=%#010x val=%#010x\n", PCNET_INST_NR,
          addr, val));
 #endif
@@ -3197 +3138 @@
 {
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetMMIOWriteU8: addr=%#010x val=%#04x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetMMIOWriteU8: addr=%#010x val=%#04x\n", PCNET_INST_NR,
          addr, val));
 #endif
@@ -3210 +3151 @@
         val = pcnetAPROMReadU8(pData, addr);
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetMMIOReadU8: addr=%#010x val=%#04x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetMMIOReadU8: addr=%#010x val=%#04x\n", PCNET_INST_NR,
          addr, val & 0xff));
 #endif
@@ -3219 +3160 @@
 {
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetMMIOWriteU16: addr=%#010x val=%#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetMMIOWriteU16: addr=%#010x val=%#06x\n", PCNET_INST_NR,
          addr, val));
 #endif
@@ -3245 +3186 @@
     }
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetMMIOReadU16: addr=%#010x val = %#06x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetMMIOReadU16: addr=%#010x val = %#06x\n", PCNET_INST_NR,
          addr, val & 0xffff));
 #endif
@@ -3254 +3195 @@
 {
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetMMIOWriteU32: addr=%#010x val=%#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetMMIOWriteU32: addr=%#010x val=%#010x\n", PCNET_INST_NR,
          addr, val));
 #endif
@@ -3286 +3227 @@
     }
 #ifdef PCNET_DEBUG_IO
-    Log2(("#%d pcnetMMIOReadU32: addr=%#010x val=%#010x\n", PCNETSTATE_2_DEVINS(pData)->iInstance,
+    Log2(("#%d pcnetMMIOReadU32: addr=%#010x val=%#010x\n", PCNET_INST_NR,
          addr, val));
 #endif
@@ -3328 +3269 @@
         else
         {
-            Log(("#%d pcnetIOPortAPromRead: Port=%RTiop cb=%d BCR_DWIO !!\n", PCNETSTATE_2_DEVINS(pData)->iInstance, Port, cb));
+            Log(("#%d pcnetIOPortAPromRead: Port=%RTiop cb=%d BCR_DWIO !!\n", PCNET_INST_NR, Port, cb));
             rc = VERR_IOM_IOPORT_UNUSED;
         }
@@ -3335 +3276 @@
     STAM_PROFILE_ADV_STOP(&pData->StatAPROMRead, a);
     LogFlow(("#%d pcnetIOPortAPromRead: Port=%RTiop *pu32=%#RX32 cb=%d rc=%Vrc\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, Port, *pu32, cb, rc));
+             PCNET_INST_NR, Port, *pu32, cb, rc));
     return rc;
 }
@@ -3361 +3302 @@
         STAM_PROFILE_ADV_START(&pData->StatAPROMWrite, a);
         rc = PDMCritSectEnter(&pData->CritSect, VINF_IOM_HC_IOPORT_WRITE);
-        if (rc == VINF_SUCCESS)
+        if (RT_LIKELY(rc == VINF_SUCCESS))
         {
             pcnetAPROMWriteU8(pData, Port, u32);
@@ -3374 +3315 @@
     }
     LogFlow(("#%d pcnetIOPortAPromWrite: Port=%RTiop u32=%#RX32 cb=%d rc=%Vrc\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, Port, u32, cb, rc));
+             PCNET_INST_NR, Port, u32, cb, rc));
+#ifdef LOG_ENABLED
+    if (rc == VINF_IOM_HC_IOPORT_WRITE)
+        LogFlow(("#%d => HC\n", PCNET_INST_NR));
+#endif
     return rc;
 }
@@ -3398 +3343 @@
     STAM_PROFILE_ADV_START(&pData->CTXSUFF(StatIORead), a);
     rc = PDMCritSectEnter(&pData->CritSect, VINF_IOM_HC_IOPORT_READ);
-    if (rc == VINF_SUCCESS)
+    if (RT_LIKELY(rc == VINF_SUCCESS))
     {
         switch (cb)
@@ -3412 +3357 @@
     STAM_PROFILE_ADV_STOP(&pData->CTXSUFF(StatIORead), a);
     LogFlow(("#%d pcnetIOPortRead: Port=%RTiop *pu32=%#RX32 cb=%d rc=%Vrc\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, Port, *pu32, cb, rc));
+             PCNET_INST_NR, Port, *pu32, cb, rc));
+#ifdef LOG_ENABLED
+    if (rc == VINF_IOM_HC_IOPORT_READ)
+        LogFlow(("#%d => HC\n", PCNET_INST_NR));
+#endif
     return rc;
 }
@@ -3436 +3385 @@
     STAM_PROFILE_ADV_START(&pData->CTXSUFF(StatIOWrite), a);
     rc = PDMCritSectEnter(&pData->CritSect, VINF_IOM_HC_IOPORT_WRITE);
-    if (rc == VINF_SUCCESS)
+    if (RT_LIKELY(rc == VINF_SUCCESS))
     {
         switch (cb)
@@ -3451 +3400 @@
     STAM_PROFILE_ADV_STOP(&pData->CTXSUFF(StatIOWrite), a);
     LogFlow(("#%d pcnetIOPortWrite: Port=%RTiop u32=%#RX32 cb=%d rc=%Vrc\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, Port, u32, cb, rc));
+             PCNET_INST_NR, Port, u32, cb, rc));
+#ifdef LOG_ENABLED
+    if (rc == VINF_IOM_HC_IOPORT_WRITE)
+        LogFlow(("#%d => HC\n", PCNET_INST_NR));
+#endif
     return rc;
 }
@@ -3480 +3433 @@
         STAM_PROFILE_ADV_START(&pData->CTXSUFF(StatMMIORead), a);
         rc = PDMCritSectEnter(&pData->CritSect, VINF_IOM_HC_MMIO_READ);
-        if (rc == VINF_SUCCESS)
+        if (RT_LIKELY(rc == VINF_SUCCESS))
         {
             switch (cb)
@@ -3500 +3453 @@
 
     LogFlow(("#%d pcnetMMIORead: pvUser=%p:{%.*Rhxs} cb=%d GCPhysAddr=%RGp rc=%Vrc\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, pv, cb, pv, cb, GCPhysAddr, rc));
+             PCNET_INST_NR, pv, cb, pv, cb, GCPhysAddr, rc));
+#ifdef LOG_ENABLED
+    if (rc == VINF_IOM_HC_MMIO_READ)
+        LogFlow(("#%d => HC\n", PCNET_INST_NR));
+#endif
     return rc;
 }
@@ -3529 +3486 @@
         STAM_PROFILE_ADV_START(&pData->CTXSUFF(StatMMIOWrite), a);
         rc = PDMCritSectEnter(&pData->CritSect, VINF_IOM_HC_MMIO_WRITE);
-        if (rc == VINF_SUCCESS)
+        if (RT_LIKELY(rc == VINF_SUCCESS))
         {
             switch (cb)
@@ -3548 +3505 @@
     }
     LogFlow(("#%d pcnetMMIOWrite: pvUser=%p:{%.*Rhxs} cb=%d GCPhysAddr=%RGp rc=%Vrc\n",
-             PCNETSTATE_2_DEVINS(pData)->iInstance, pv, cb, pv, cb, GCPhysAddr, rc));
+             PCNET_INST_NR, pv, cb, pv, cb, GCPhysAddr, rc));
+#ifdef LOG_ENABLED
+    if (rc == VINF_IOM_HC_MMIO_WRITE)
+        LogFlow(("#%d => HC\n", PCNET_INST_NR));
+#endif
     return rc;
 }
@@ -4424 +4385 @@
     rc = CFGMR3QueryU32(pCfgHandle, "LineSpeed", &pData->u32LinkSpeed);
     if (rc == VERR_CFGM_VALUE_NOT_FOUND)
-        pData->u32LinkSpeed = 100000;    /* 100 Mbps (in kbps units)*/
+        pData->u32LinkSpeed = 1000000;    /* 1GBit/s (in kbps units)*/
     else if (VBOX_FAILURE(rc))
         return PDMDEV_SET_ERROR(pDevIns, rc,
@@ -4659 +4620 @@
     pData->ulXmitRingBufProd   = 0;
     pData->ulXmitRingBufCons   = 0;
-    pData->pXmitRingBuffer[0]  = (char *)RTMemAlloc(PCNET_MAX_XMIT_SLOTS * 1536);
+    pData->pXmitRingBuffer[0]  = (char *)RTMemAlloc(PCNET_MAX_XMIT_SLOTS * MAX_FRAME);
     pData->cbXmitRingBuffer[0] = 0;
     for (i = 1; i < PCNET_MAX_XMIT_SLOTS; i++)
     {
-        pData->pXmitRingBuffer[i]  = pData->pXmitRingBuffer[i-1] + 1536;
+        pData->pXmitRingBuffer[i]  = pData->pXmitRingBuffer[i-1] + MAX_FRAME;
         pData->cbXmitRingBuffer[i] = 0;
     }
@@ -4698 +4659 @@
 
     for (i = 0; i < ELEMENTS(pData->aStatXmitFlush) - 1; i++)
-        PDMDevHlpSTAMRegisterF(pDevIns, &pData->aStatXmitFlush[i],  STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES, "",                                       "/Devices/PCNet%d/XmitFlushIrq/%d", iInstance, i + 1);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->aStatXmitFlush[i],      STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,    "",                                    "/Devices/PCNet%d/XmitFlushIrq/%d+", iInstance, i + 1);
+        PDMDevHlpSTAMRegisterF(pDevIns, &pData->aStatXmitFlush[i],  STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,       "",                                   "/Devices/PCNet%d/XmitFlushIrq/%d", iInstance, i + 1);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->aStatXmitFlush[i],      STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,       "",                                   "/Devices/PCNet%d/XmitFlushIrq/%d+", iInstance, i + 1);
 
     for (i = 0; i < ELEMENTS(pData->aStatXmitChainCounts) - 1; i++)
-        PDMDevHlpSTAMRegisterF(pDevIns, &pData->aStatXmitChainCounts[i], STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES, "",                                  "/Devices/PCNet%d/XmitChainCounts/%d", iInstance, i + 1);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->aStatXmitChainCounts[i], STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,    "",                                   "/Devices/PCNet%d/XmitChainCounts/%d+", iInstance, i + 1);
-
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatXmitSkipCurrent,    STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,    "",                                    "/Devices/PCNet%d/Xmit/Skipped", iInstance, i + 1);
+        PDMDevHlpSTAMRegisterF(pDevIns, &pData->aStatXmitChainCounts[i], STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,  "",                                   "/Devices/PCNet%d/XmitChainCounts/%d", iInstance, i + 1);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->aStatXmitChainCounts[i], STAMTYPE_COUNTER, STAMVISIBILITY_USED, STAMUNIT_OCCURENCES,      "",                                   "/Devices/PCNet%d/XmitChainCounts/%d+", iInstance, i + 1);
+
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatXmitSkipCurrent,    STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "",                                   "/Devices/PCNet%d/Xmit/Skipped", iInstance, i + 1);
 
     PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatInterrupt,          STAMTYPE_PROFILE, STAMVISIBILITY_ALWAYS, STAMUNIT_TICKS_PER_CALL, "Profiling PCNet interrupt checks",   "/Devices/PCNet%d/UpdateIRQ", iInstance);
@@ -4716 +4677 @@
     PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteR0,        STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of monitored ring page writes",   "/Devices/PCNet%d/Ring/R0/Writes", iInstance);
     PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteGC,        STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of monitored ring page writes",   "/Devices/PCNet%d/Ring/GC/Writes", iInstance);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteFailedHC,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of failed ring page writes",   "/Devices/PCNet%d/Ring/HC/Failed", iInstance);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteFailedR0,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of failed ring page writes",   "/Devices/PCNet%d/Ring/R0/Failed", iInstance);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteFailedGC,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of failed ring page writes",   "/Devices/PCNet%d/Ring/GC/Failed", iInstance);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteOutsideRangeHC,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of monitored writes outside ring range",   "/Devices/PCNet%d/Ring/HC/Outside", iInstance);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteOutsideRangeR0,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of monitored writes outside ring range",   "/Devices/PCNet%d/Ring/R0/Outside", iInstance);
-    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteOutsideRangeGC,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of monitored writes outside ring range",   "/Devices/PCNet%d/Ring/GC/Outside", iInstance);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteFailedHC,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of failed ring page writes",      "/Devices/PCNet%d/Ring/HC/Failed", iInstance);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteFailedR0,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of failed ring page writes",      "/Devices/PCNet%d/Ring/R0/Failed", iInstance);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteFailedGC,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES,     "Nr of failed ring page writes",      "/Devices/PCNet%d/Ring/GC/Failed", iInstance);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteOutsideRangeHC,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES, "Nr of monitored writes outside ring range", "/Devices/PCNet%d/Ring/HC/Outside", iInstance);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteOutsideRangeR0,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES, "Nr of monitored writes outside ring range", "/Devices/PCNet%d/Ring/R0/Outside", iInstance);
+    PDMDevHlpSTAMRegisterF(pDevIns, &pData->StatRingWriteOutsideRangeGC,  STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_OCCURENCES, "Nr of monitored writes outside ring range", "/Devices/PCNet%d/Ring/GC/Outside", iInstance);
 # endif /* PCNET_NO_POLLING */
 #endif