Changeset 73581 in vbox for trunk/src/VBox

Timestamp:

Aug 9, 2018 9:27:19 AM (6 years ago)

Author:

vboxsync

Message:

Audio/Mixer: Skip handling input streams which currently are not marked as the recording source -- should save a few CPU cycles.

File:

• trunk/src/VBox/Devices/Audio/AudioMixer.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/AudioMixer.cpp

@@ -675 +675 @@
         return rc;
 
+    /* Input sink and no recording source set? Bail out early. */
+    if (   pSink->enmDir == AUDMIXSINKDIR_INPUT
+        && pSink->In.pStreamRecSource == NULL)
+    {
+        int rc2 = RTCritSectLeave(&pSink->CritSect);
+        AssertRC(rc2);
+
+        return rc;
+    }
+
     PAUDMIXSTREAM pStream;
-    RTListForEach(&pSink->lstStreams, pStream, AUDMIXSTREAM, Node)
-    {
-        int rc2 = audioMixerStreamCtlInternal(pStream, enmCmdStream, AUDMIXSTRMCTL_FLAG_NONE);
-        if (RT_SUCCESS(rc))
-            rc = rc2;
-        /* Keep going. Flag? */
+    if (   pSink->enmDir == AUDMIXSINKDIR_INPUT
+        && pSink->In.pStreamRecSource) /* Any recording source set? */
+    {
+        RTListForEach(&pSink->lstStreams, pStream, AUDMIXSTREAM, Node)
+        {
+            if (pStream == pSink->In.pStreamRecSource)
+            {
+                int rc2 = audioMixerStreamCtlInternal(pStream, enmCmdStream, AUDMIXSTRMCTL_FLAG_NONE);
+                if (RT_SUCCESS(rc))
+                    rc = rc2;
+                /* Keep going. Flag? */
+            }
+        }
+    }
+    else if (pSink->enmDir == AUDMIXSINKDIR_OUTPUT)
+    {
+        RTListForEach(&pSink->lstStreams, pStream, AUDMIXSTREAM, Node)
+        {
+            int rc2 = audioMixerStreamCtlInternal(pStream, enmCmdStream, AUDMIXSTRMCTL_FLAG_NONE);
+            if (RT_SUCCESS(rc))
+                rc = rc2;
+            /* Keep going. Flag? */
+        }
     }
 
@@ -1504 +1531 @@
         return rc;
 
+    /* Input sink and no recording source set? Bail out early. */
+    if (   pSink->enmDir == AUDMIXSINKDIR_INPUT
+        && pSink->In.pStreamRecSource == NULL)
+        return rc;
+
     /* Number of detected disabled streams of this sink. */
     uint8_t cStreamsDisabled = 0;
@@ -1510 +1542 @@
     RTListForEachSafe(&pSink->lstStreams, pMixStream, pMixStreamNext, AUDMIXSTREAM, Node)
     {
+        /* Input sink and not the recording source? Skip. */
+        if (   pSink->enmDir == AUDMIXSINKDIR_INPUT
+            && pSink->In.pStreamRecSource != pMixStream)
+            continue;
+
         PPDMAUDIOSTREAM pStream   = pMixStream->pStream;
         AssertPtr(pStream);