Changeset 73586 in vbox for trunk/src/VBox/Frontends

Timestamp:

Aug 9, 2018 1:34:57 PM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:6596 Adding a size check for FAT file systems in create new hdd wizards

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIMessageCenter.cpp (modified) (2 diffs)
• globals/UIMessageCenter.h (modified) (1 diff)
• wizards/newvd/UIWizardNewVD.cpp (modified) (1 diff)
• wizards/newvd/UIWizardNewVDPageBasic3.cpp (modified) (4 diffs)
• wizards/newvd/UIWizardNewVDPageBasic3.h (modified) (1 diff)
• wizards/newvd/UIWizardNewVDPageExpert.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.cpp

@@ -1688 +1688 @@
 }
 
+void UIMessageCenter::cannotCreateHardDiskStorageInFAT(const QString &strLocation, QWidget *pParent /* = 0 */) const
+{
+    error(pParent, MessageType_Error,
+          tr("Failed to create the hard disk storage <nobr><b>%1</b>.</nobr> FAT file systems has 4GB (minus some overhead) size limit")
+          .arg(strLocation), QString());
+}
+
 void UIMessageCenter::cannotCreateMediumStorage(const CVirtualBox &comVBox, const QString &strLocation, QWidget *pParent /* = 0 */) const
 {
@@ -2889 +2896 @@
     return iResultCode;
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.h

@@ -370 +370 @@
     void cannotCreateHardDiskStorage(const CMedium &medium, const QString &strLocation, QWidget *pParent = 0) const;
     void cannotCreateHardDiskStorage(const CProgress &progress, const QString &strLocation, QWidget *pParent = 0) const;
+    void cannotCreateHardDiskStorageInFAT(const QString &strLocation, QWidget *pParent = 0) const;
     void cannotCreateMediumStorage(const CVirtualBox &comVBox, const QString &strLocation, QWidget *pParent = 0) const;
     void cannotCreateMediumStorage(const CMedium &comMedium, const QString &strLocation, QWidget *pParent = 0) const;

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvd/UIWizardNewVD.cpp

@@ -151 +151 @@
     UIWizard::prepare();
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvd/UIWizardNewVDPageBasic3.cpp

@@ -48 +48 @@
 #endif /* !VBOX_WITH_PRECOMPILED_HEADERS */
 
+/* Other VBox includes: */
+#include <iprt/path.h>
 
 UIWizardNewVDPage3::UIWizardNewVDPage3(const QString &strDefaultName, const QString &strDefaultPath)
@@ -262 +264 @@
 
     if (fResult)
+        fResult = checkFATSizeLimitation();
+
+    if (!fResult)
+        msgCenter().cannotCreateHardDiskStorageInFAT(strMediumPath, this);
+    else
     {
         /* Lock finish button: */
@@ -268 +275 @@
         /* Try to create virtual hard drive file: */
         fResult = qobject_cast<UIWizardNewVD*>(wizard())->createVirtualDisk();
-
-        /* Unlock finish button: */
+       /* Unlock finish button: */
         endProcessing();
     }
@@ -277 +283 @@
 }
 
+bool UIWizardNewVDPage3::checkFATSizeLimitation()
+{
+    QString strMediumPath(mediumPath());
+    RTFSTYPE enmType;
+    int rc = RTFsQueryType(QFileInfo(strMediumPath).absolutePath().toLatin1().constData(), &enmType);
+    if (RT_SUCCESS(rc))
+    {
+        if (enmType == RTFSTYPE_FAT)
+        {
+            /* Limit the medium size to 4GB. minus 128 MB for file overhead: */
+            qulonglong fatLimit = 4 * pow(2,30) - 128 * pow(2, 20);
+            if (mediumSize() >= fatLimit)
+                return false;
+        }
+    }
+    return true;
+}

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvd/UIWizardNewVDPageBasic3.h

@@ -45 +45 @@
     static QString absoluteFilePath(const QString &strFileName, const QString &strDefaultPath);
     static QString defaultExtension(const CMediumFormat &mediumFormatRef);
+
+    /* Checks if the medium file is bigger than what is allowed in FAT file systems. */
+    bool checkFATSizeLimitation();
 
     /* Stuff for 'mediumPath' field: */

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvd/UIWizardNewVDPageExpert.cpp

@@ -269 +269 @@
         msgCenter().cannotOverwriteHardDiskStorage(strMediumPath, this);
 
+    if (fResult)
+        fResult = checkFATSizeLimitation();
+
+    if (!fResult)
+        msgCenter().cannotCreateHardDiskStorageInFAT(strMediumPath, this);
+
     /* Try to create virtual-disk: */
     if (fResult)
@@ -279 +285 @@
     return fResult;
 }
-