Changeset 73589 in vbox for trunk/src/VBox

Timestamp:

Aug 9, 2018 1:56:15 PM (6 years ago)

Author:

vboxsync

Message:

Main: Allow changing the passthrough flag when the VM is running if the storage controller supports hot plugging

Location:

trunk/src/VBox

Files:

• Devices/Storage/DrvSCSI.cpp (modified) (1 diff)
• Main/src-server/MachineImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/DrvSCSI.cpp

@@ -1230 +1230 @@
 
     LogFlowFunc(("pDrvIns=%#p fFlags=%#x\n", pDrvIns, fFlags));
-
-    AssertMsgReturnVoid((fFlags & PDM_TACH_FLAGS_NOT_HOT_PLUG),
-                        ("SCSI: Hotplugging is not supported\n"));
 
     /*

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -4507 +4507 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    HRESULT rc = i_checkStateDependency(MutableStateDep);
+    HRESULT rc = i_checkStateDependency(MutableOrRunningStateDep);
     if (FAILED(rc)) return rc;
 
     AssertReturn(mData->mMachineState != MachineState_Saved, E_FAIL);
 
-    if (Global::IsOnlineOrTransient(mData->mMachineState))
+    /* Check for an existing controller. */
+    ComObjPtr<StorageController> ctl;
+    rc = i_getStorageControllerByName(aName, ctl, true /* aSetError */);
+    if (FAILED(rc)) return rc;
+
+    StorageControllerType_T ctrlType;
+    rc = ctl->COMGETTER(ControllerType)(&ctrlType);
+    if (FAILED(rc))
+        return setError(E_FAIL,
+                        tr("Could not get type of controller '%s'"),
+                        aName.c_str());
+
+    bool fSilent = false;
+    Utf8Str strReconfig;
+
+    /* Check whether the flag to allow silent storage attachment reconfiguration is set. */
+    strReconfig = i_getExtraData(Utf8Str("VBoxInternal2/SilentReconfigureWhilePaused"));
+    if (   mData->mMachineState == MachineState_Paused
+        && strReconfig == "1")
+        fSilent = true;
+
+    /* Check that the controller can do hotplugging if we detach the device while the VM is running. */
+    bool fHotplug = false;
+    if (!fSilent && Global::IsOnlineOrTransient(mData->mMachineState))
+        fHotplug = true;
+
+    if (fHotplug && !i_isControllerHotplugCapable(ctrlType))
         return setError(VBOX_E_INVALID_VM_STATE,
-                        tr("Invalid machine state: %s"),
-                        Global::stringifyMachineState(mData->mMachineState));
+                        tr("Controller '%s' does not support hotplugging which is required to change the passthrough setting while the VM is running"),
+                        aName.c_str());
 
     MediumAttachment *pAttach = i_findAttachment(*mMediumAttachments.data(),
@@ -4538 +4564 @@
     pAttach->i_updatePassthrough(!!aPassthrough);
 
-    return S_OK;
+    attLock.release();
+    alock.release();
+    rc = i_onStorageDeviceChange(pAttach, FALSE /* aRemove */, FALSE /* aSilent */);
+
+    return rc;
 }