Changeset 73616 in vbox for trunk/src/VBox/Runtime/common/misc

Timestamp:

Aug 10, 2018 1:43:18 PM (6 years ago)

Author:

vboxsync

Message:

Runtime/RTJson: Promote type assertions In query functions to always
executed type checks.

File:

• trunk/src/VBox/Runtime/common/misc/json.cpp (modified) (10 diffs)

trunk/src/VBox/Runtime/common/misc/json.cpp

@@ -1289 +1289 @@
 {
     PRTJSONVALINT pThis = hJsonVal;
+    AssertPtrReturn(pThis, RTJSONVALTYPE_INVALID);
+
     if (pThis == NIL_RTJSONVAL)
         return RTJSONVALTYPE_INVALID;
-    AssertPtrReturn(pThis, RTJSONVALTYPE_INVALID);
 
     return pThis->enmType;
 }
 
+
+#define AssertJsonTypeReturn(pJson, enmExpectedType, ret) do {          \
+        AssertPtrReturn((pJson), (ret));                                \
+        AssertReturn((pJson) != NIL_RTJSONVAL, (ret));                  \
+        AssertReturn((pJson)->enmType == (enmExpectedType), (ret));     \
+    } while (0)
+
+#define RTJSON_TYPECHECK(pJson, enmExpectedType) do {   \
+        if (RT_UNLIKELY((pJson) == NIL_RTJSONVAL))      \
+            return VERR_INVALID_HANDLE;                 \
+        if ((pJson)->enmType != (enmExpectedType))      \
+            return VERR_JSON_VALUE_INVALID_TYPE;        \
+    } while (0)
+
+
+#define RTJSON_TYPECHECK_CONTAINER(pJson) do {                  \
+        if (RT_UNLIKELY((pJson) == NIL_RTJSONVAL))              \
+            return VERR_INVALID_HANDLE;                         \
+        if (   (pJson)->enmType != RTJSONVALTYPE_ARRAY          \
+            && (pJson)->enmType != RTJSONVALTYPE_OBJECT)        \
+            return VERR_JSON_VALUE_INVALID_TYPE;                \
+    } while (0)
+
+
 RTDECL(const char *) RTJsonValueGetString(RTJSONVAL hJsonVal)
 {
     PRTJSONVALINT pThis = hJsonVal;
-    AssertReturn(pThis != NIL_RTJSONVAL, NULL);
-    AssertReturn(pThis->enmType == RTJSONVALTYPE_STRING, NULL);
+    AssertJsonTypeReturn(pThis, RTJSONVALTYPE_STRING, NULL);
 
     return pThis->Type.String.pszStr;
 }
 
+
 RTDECL(int) RTJsonValueQueryString(RTJSONVAL hJsonVal, const char **ppszStr)
 {
     PRTJSONVALINT pThis = hJsonVal;
+    AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertPtrReturn(ppszStr, VERR_INVALID_POINTER);
-    AssertReturn(pThis != NIL_RTJSONVAL, VERR_INVALID_HANDLE);
-    AssertReturn(pThis->enmType == RTJSONVALTYPE_STRING, VERR_JSON_VALUE_INVALID_TYPE);
-
+
+    RTJSON_TYPECHECK(pThis, RTJSONVALTYPE_STRING);
     *ppszStr = pThis->Type.String.pszStr;
     return VINF_SUCCESS;
@@ -1319 +1344 @@
 {
     PRTJSONVALINT pThis = hJsonVal;
+    AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertPtrReturn(pi64Num, VERR_INVALID_POINTER);
-    AssertReturn(pThis != NIL_RTJSONVAL, VERR_INVALID_HANDLE);
-    AssertReturn(pThis->enmType == RTJSONVALTYPE_NUMBER, VERR_JSON_VALUE_INVALID_TYPE);
-
+
+    RTJSON_TYPECHECK(pThis, RTJSONVALTYPE_NUMBER);
     *pi64Num = pThis->Type.Number.i64Num;
     return VINF_SUCCESS;
@@ -1330 +1355 @@
 {
     PRTJSONVALINT pThis = hJsonVal;
+    AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertPtrReturn(pszName, VERR_INVALID_POINTER);
     AssertPtrReturn(phJsonVal, VERR_INVALID_POINTER);
-    AssertReturn(pThis != NIL_RTJSONVAL, VERR_INVALID_HANDLE);
-    AssertReturn(pThis->enmType == RTJSONVALTYPE_OBJECT, VERR_JSON_VALUE_INVALID_TYPE);
+
+    RTJSON_TYPECHECK(pThis, RTJSONVALTYPE_OBJECT);
 
     int rc = VERR_NOT_FOUND;
@@ -1407 +1433 @@
 {
     PRTJSONVALINT pThis = hJsonVal;
-    AssertReturn(pThis != NIL_RTJSONVAL, 0);
-    AssertReturn(pThis->enmType == RTJSONVALTYPE_ARRAY, 0);
+    AssertJsonTypeReturn(pThis, RTJSONVALTYPE_ARRAY, 0);
 
     return pThis->Type.Array.cItems;
@@ -1416 +1441 @@
 {
     PRTJSONVALINT pThis = hJsonVal;
+    AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertPtrReturn(pcItems, VERR_INVALID_POINTER);
-    AssertReturn(pThis != NIL_RTJSONVAL, VERR_INVALID_HANDLE);
-    AssertReturn(pThis->enmType == RTJSONVALTYPE_ARRAY, VERR_JSON_VALUE_INVALID_TYPE);
-
+
+    RTJSON_TYPECHECK(pThis, RTJSONVALTYPE_ARRAY);
     *pcItems = pThis->Type.Array.cItems;
     return VINF_SUCCESS;
@@ -1427 +1452 @@
 {
     PRTJSONVALINT pThis = hJsonVal;
+    AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertPtrReturn(phJsonVal, VERR_INVALID_POINTER);
-    AssertReturn(pThis != NIL_RTJSONVAL, VERR_INVALID_HANDLE);
-    AssertReturn(pThis->enmType == RTJSONVALTYPE_ARRAY, VERR_JSON_VALUE_INVALID_TYPE);
-    AssertReturn(idx < pThis->Type.Array.cItems, VERR_OUT_OF_RANGE);
+
+    RTJSON_TYPECHECK(pThis, RTJSONVALTYPE_ARRAY);
+    if (RT_UNLIKELY(idx >= pThis->Type.Array.cItems))
+        return VERR_OUT_OF_RANGE;
 
     RTJsonValueRetain(pThis->Type.Array.papItems[idx]);
@@ -1440 +1467 @@
 {
     PRTJSONVALINT pThis = hJsonVal;
+    AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertPtrReturn(phJsonIt, VERR_INVALID_POINTER);
-    AssertReturn(pThis != NIL_RTJSONVAL, VERR_INVALID_HANDLE);
-    AssertReturn(pThis->enmType == RTJSONVALTYPE_ARRAY || pThis->enmType == RTJSONVALTYPE_OBJECT,
-                 VERR_JSON_VALUE_INVALID_TYPE);
+
+    RTJSON_TYPECHECK_CONTAINER(pThis);
 
     PRTJSONITINT pIt = (PRTJSONITINT)RTMemTmpAllocZ(sizeof(RTJSONITINT));
@@ -1460 +1487 @@
 {
     PRTJSONITINT pIt = hJsonIt;
+    AssertPtrReturn(pIt, VERR_INVALID_HANDLE);
     AssertReturn(pIt != NIL_RTJSONIT, VERR_INVALID_HANDLE);
     AssertPtrReturn(phJsonVal, VERR_INVALID_POINTER);
@@ -1500 +1528 @@
 {
     PRTJSONITINT pIt = hJsonIt;
+    AssertPtrReturn(pIt, VERR_INVALID_HANDLE);
     AssertReturn(pIt != NIL_RTJSONIT, VERR_INVALID_HANDLE);
 
@@ -1529 +1558 @@
 {
     PRTJSONITINT pThis = hJsonIt;
+    AssertPtrReturnVoid(pThis);
+
     if (pThis == NIL_RTJSONIT)
         return;
-    AssertPtrReturnVoid(pThis);
 
     RTJsonValueRelease(pThis->pJsonVal);
     RTMemTmpFree(pThis);
 }
-