Changeset 73647 in vbox

Timestamp:

Aug 14, 2018 11:35:39 AM (6 years ago)

Author:

vboxsync

Message:

Audio/AC97: Don't destroy a stream's circular buffer on stream close, as there might be data in, which haven't been processed yet. Instead, destroy it when re-opening the stream and on stream destruction.

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -1016 +1016 @@
     }
 
+    if (pStream->State.pCircBuf)
+    {
+        RTCircBufDestroy(pStream->State.pCircBuf);
+        pStream->State.pCircBuf = NULL;
+    }
+
     LogFlowFuncLeave();
 }
@@ -1856 +1862 @@
             pCfg->Props.cShift    = PDMAUDIOPCMPROPS_MAKE_SHIFT_PARMS(pCfg->Props.cBytes, pCfg->Props.cChannels);
 
-            rc = RTCircBufCreate(&pStream->State.pCircBuf, DrvAudioHlpMilliToBytes(100 /* ms */, &pCfg->Props)); /** @todo Make this configurable. */
+            if (pStream->State.pCircBuf)
+            {
+                RTCircBufDestroy(pStream->State.pCircBuf);
+                pStream->State.pCircBuf = NULL;
+            }
+
+            rc = RTCircBufCreate(&pStream->State.pCircBuf, DrvAudioHlpMilliToBytes(500 /* ms */, &pCfg->Props)); /** @todo Make this configurable. */
             if (RT_SUCCESS(rc))
                 rc = ichac97R3MixerAddDrvStreams(pThis, pMixSink, pCfg);
@@ -1878 +1890 @@
 
     LogFlowFunc(("[SD%RU8]\n", pStream->u8SD));
-
-    if (pStream->State.pCircBuf)
-    {
-        RTCircBufDestroy(pStream->State.pCircBuf);
-        pStream->State.pCircBuf = NULL;
-    }
 
     return VINF_SUCCESS;