Changeset 73652 in vbox for trunk/src

Timestamp:

Aug 14, 2018 12:46:49 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

124326

Message:

Audio/DrvAudio: Get rid of the (internal) mixing buffer factors, as this hides timing problems and isn't needed anyway.

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -617 +617 @@
              pStream->szName, msPeriod, CfgHostAcq.Backend.cfPeriod));
 
-    /* Set set host buffer size multiplicator. */
-    const unsigned cHstBufferFactor = 2; /** @todo Make this configurable. */
-
     /* Destroy any former mixing buffer. */
     AudioMixBufDestroy(&pStream->Host.MixBuf);
@@ -626 +623 @@
     CfgHostAcq.Props.cShift = PDMAUDIOPCMPROPS_MAKE_SHIFT_PARMS(CfgHostAcq.Props.cBytes, CfgHostAcq.Props.cChannels);
 
-    rc = AudioMixBufInit(&pStream->Host.MixBuf, pStream->szName, &CfgHostAcq.Props,
-                        CfgHostAcq.Backend.cfBufferSize * cHstBufferFactor);
+    rc = AudioMixBufInit(&pStream->Host.MixBuf, pStream->szName, &CfgHostAcq.Props, CfgHostAcq.Backend.cfBufferSize);
     AssertRC(rc);
 
@@ -652 +648 @@
     pCfgGuest->Props.cShift = PDMAUDIOPCMPROPS_MAKE_SHIFT_PARMS(pCfgGuest->Props.cBytes, pCfgGuest->Props.cChannels);
 
-    /* Set set guest buffer size multiplicator. */
-    const unsigned cGstBufferFactor = 4; /** @todo Make this configurable. */
-
-    rc = AudioMixBufInit(&pStream->Guest.MixBuf, pStream->szName, &pCfgGuest->Props,
-                         CfgHostAcq.Backend.cfBufferSize * cGstBufferFactor);
+    rc = AudioMixBufInit(&pStream->Guest.MixBuf, pStream->szName, &pCfgGuest->Props, CfgHostAcq.Backend.cfBufferSize);
     AssertRC(rc);