Changeset 73656 in vbox

Timestamp:

Aug 14, 2018 1:04:14 PM (6 years ago)

Author:

vboxsync

Message:

Audio/PulseAudio: D'oh, follow-up to messed up commit r124328 ("Double buffering" not needed here; logging tweak for underruns).

File:

• trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp

@@ -771 +771 @@
     pCfgAcq->Props.cShift    = PDMAUDIOPCMPROPS_MAKE_SHIFT_PARMS(pCfgAcq->Props.cBytes, pCfgAcq->Props.cChannels);
 
-    uint32_t cbBuf = RT_MIN(pStreamPA->BufAttr.tlength * 2,
-                            pStreamPA->BufAttr.maxlength); /** @todo Make this configurable! */
-
     LogFunc(("Acquired: BufAttr tlength=%RU32, maxLength=%RU32, minReq=%RU32\n",
              pStreamPA->BufAttr.tlength, pStreamPA->BufAttr.maxlength, pStreamPA->BufAttr.minreq));
 
-    if (cbBuf)
-    {
-        pCfgAcq->Backend.cfPeriod     = PDMAUDIOSTREAMCFG_B2F(pCfgAcq, pStreamPA->BufAttr.minreq);
-        pCfgAcq->Backend.cfBufferSize = PDMAUDIOSTREAMCFG_B2F(pCfgAcq, pStreamPA->BufAttr.tlength * 2); /* Use "double buffering". */
-        pCfgAcq->Backend.cfPreBuf     = PDMAUDIOSTREAMCFG_B2F(pCfgAcq, pStreamPA->BufAttr.prebuf);
-
-        pStreamPA->pDrv = pThis;
-    }
-    else
-        rc = VERR_INVALID_PARAMETER;
+    pCfgAcq->Backend.cfPeriod     = PDMAUDIOSTREAMCFG_B2F(pCfgAcq, pStreamPA->BufAttr.minreq);
+    pCfgAcq->Backend.cfBufferSize = PDMAUDIOSTREAMCFG_B2F(pCfgAcq, pStreamPA->BufAttr.tlength);
+    pCfgAcq->Backend.cfPreBuf     = PDMAUDIOSTREAMCFG_B2F(pCfgAcq, pStreamPA->BufAttr.prebuf);
+
+    pStreamPA->pDrv = pThis;
 
     return rc;