Changeset 73684 in vbox

Timestamp:

Aug 15, 2018 9:12:56 AM (6 years ago)

Author:

vboxsync

Message:

Audio/DrvAudio: Added simple debug sanity checks for buggy acquired backend configurations in drvAudioStreamCreateInternalBackend().

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -3053 +3053 @@
                  pStream->szName, DrvAudioHlpFramesToMilli(pCfgAcq->Backend.cfPreBuf, &pCfgAcq->Props), pCfgAcq->Backend.cfPreBuf));
     }
+
+    /* Sanity for detecting buggy backends. */
+    AssertMsgReturn(pCfgAcq->Backend.cfPeriod < pCfgAcq->Backend.cfBufferSize,
+                    ("Acquired period size must be smaller than buffer size\n"),
+                    VERR_INVALID_PARAMETER);
+    AssertMsgReturn(pCfgAcq->Backend.cfPreBuf < pCfgAcq->Backend.cfBufferSize,
+                    ("Acquired pre-buffering size must be smaller than buffer size -- this otherwise will lead to buffer overruns\n"),
+                    VERR_INVALID_PARAMETER);
 
     pStream->fStatus |= PDMAUDIOSTREAMSTS_FLAG_INITIALIZED;