Changeset 74064 in vbox

Timestamp:

Sep 4, 2018 12:37:35 PM (6 years ago)

Author:

vboxsync

Message:

IPRT/http: Added prototype for RTHttpSignHeaders. bugref:9167

Location:

trunk

Files:

• include/iprt/http.h (modified) (1 diff)
• src/VBox/Runtime/generic/http-curl.cpp (modified) (2 diffs)

trunk/include/iprt/http.h

@@ -335 +335 @@
 
 /**
+ * Sign all headers present according to pending "Signing HTTP Messages" RFC.
+ *
+ * Currently hardcoded RSA-SHA-256 algorithm choice.
+ *
+ * @returns IPRT status code.
+ * @param   hHttp           The HTTP client handle.
+ * @param   enmMethod       The HTTP method that will be used for the request.
+ * @param   pszUrl          The target URL for the request.
+ * @param   hKey            The RSA key to use when signing.
+ * @param   pszKeyId        The key ID string corresponding to @a hKey.
+ * @param   fFlags          Reserved for future, MBZ.
+ *
+ * @note    Caller is responsible for making all desired fields are present before
+ *          making the call.
+ *
+ * @remarks Latest RFC draft at the time of writing:
+ *          https://tools.ietf.org/html/draft-cavage-http-signatures-10
+ */
+RTR3DECL(int) RTHttpSignHeaders(RTHTTP hHttp, RTHTTPMETHOD enmMethod, const char *pszUrl,
+                                RTCRKEY hKey, const char *pszKeyId, uint32_t fFlags);
+
+/**
  * Tells the HTTP client instance to gather system CA certificates into a
  * temporary file and use it for HTTPS connections.

trunk/src/VBox/Runtime/generic/http-curl.cpp

@@ -2208 +2208 @@
 
 
-RTR3DECL(int) RTHttpSignHeaders(RTHTTP hHttp, RTHTTPMETHOD enmMethod, const char *pszUrl, uint32_t fFlags,
-                                RTCRKEY hKey, const char *pszKeyId)
+RTR3DECL(int) RTHttpSignHeaders(RTHTTP hHttp, RTHTTPMETHOD enmMethod, const char *pszUrl,
+                                RTCRKEY hKey, const char *pszKeyId, uint32_t fFlags)
 {
     PRTHTTPINTERNAL pThis = hHttp;
@@ -2348 +2348 @@
                 if (RT_SUCCESS(rc))
                 {
+                    Assert(cbActual == cbSigRaw);
                     RTCrPkixSignatureRelease(hSigner);
                     hSigner = NIL_RTCRPKIXSIGNATURE;