Changeset 74076 in vbox

Timestamp:

Sep 5, 2018 8:27:18 AM (6 years ago)

Author:

vboxsync

Message:

IPRT/http: Simplified the append-to-empty-list case in rtHttpAddHeaderWorker. bugref:9167

File:

• trunk/src/VBox/Runtime/generic/http-curl.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/generic/http-curl.cpp

@@ -2036 +2036 @@
 
         /*
-         * Append or prepend the header.
+         * Appending to an existing list requires no cURL interaction.
          */
         AssertCompile(RTHTTPADDHDR_F_FRONT != 0);
-        if (!(fFlags & RTHTTPADDHDR_F_FRONT))
-        {
-            bool const fDone = pThis->pHeaders != NULL;
-            ASMCompilerBarrier(); /* aliasing paranoia */
-
+        if (   !(fFlags & RTHTTPADDHDR_F_FRONT)
+            && pThis->pHeaders != NULL)
+        {
             *pThis->ppHeadersTail = &pHdr->Core;
             pThis->ppHeadersTail  = &pHdr->Core.next;
-            if (fDone)
-                return rtHttpUpdateUserAgentHeader(pThis, pHdr);
-
-            /* Need to update curl about the new list head. */
-        }
-        else
-        {
-            pHdr->Core.next = pThis->pHeaders;
-            if (!pThis->pHeaders)
-                pThis->ppHeadersTail = &pHdr->Core.next;
-        }
+            return rtHttpUpdateUserAgentHeader(pThis, pHdr);
+        }
+
+        /*
+         * When prepending or adding the first header we need to inform cURL
+         * about the new list head.
+         */
+        pHdr->Core.next = pThis->pHeaders;
+        if (!pThis->pHeaders)
+            pThis->ppHeadersTail = &pHdr->Core.next;
         pThis->pHeaders = &pHdr->Core;