Changeset 74252 in vbox

Timestamp:

Sep 13, 2018 5:22:06 PM (6 years ago)

Author:

vboxsync

Message:

IPRT/dbgstackdumpself: Another shot at the solaris linking issue. bugref:9152

Location:

trunk/src/VBox/Runtime

Files:

• common/dbg/dbgstackdumpself.cpp (modified) (2 diffs)
• tools/RTKrnlModInfo.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/dbg/dbgstackdumpself.cpp

@@ -95 +95 @@
 *   Internal Functions                                                                                                           *
 *********************************************************************************************************************************/
+/* Wanted to use DECLHIDDEN(DECLASM(size_t)) here, but early solaris 11 doesn't like it. */
 RT_C_DECLS_BEGIN
-DECLASM(DECLHIDDEN(size_t)) rtDbgStackDumpSelfWorker(char *pszStack, size_t cbStack, uint32_t fFlags, PCRTCCUINTREG pauRegs);
+DECLHIDDEN(DECLCALLBACK(size_t)) rtDbgStackDumpSelfWorker(char *pszStack, size_t cbStack, uint32_t fFlags, PCRTCCUINTREG pauRegs);
 RT_C_DECLS_END
 
@@ -360 +361 @@
  *                      PC and us followed by the general purpose registers.
  */
-DECLASM(DECLHIDDEN(size_t)) rtDbgStackDumpSelfWorker(char *pszStack, size_t cbStack, uint32_t fFlags, PCRTCCUINTREG pauRegs)
+DECLHIDDEN(DECLCALLBACK(size_t)) rtDbgStackDumpSelfWorker(char *pszStack, size_t cbStack, uint32_t fFlags, PCRTCCUINTREG pauRegs)
 {
     RT_NOREF(fFlags);

trunk/src/VBox/Runtime/tools/RTKrnlModInfo.cpp

@@ -49 +49 @@
         return RTMsgInitFailure(rc);
 
+    /** @todo proper argument parsing, please. */
+    if (argc != 1)
+    {
+        RTMsgError("Syntax error: This tool takes no parameters.  It just lists the modules\n");
+        return RTEXITCODE_SYNTAX;
+    }
+
     RTEXITCODE rcExit = RTEXITCODE_SUCCESS;
     uint32_t cKrnlMods = RTKrnlModLoadedGetCount();