Changeset 7428 in vbox for trunk

Timestamp:

Mar 12, 2008 9:58:58 AM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

28863

Message:

Use explicit initialization of all members and not lazy {0}.

Location:

trunk/src/VBox/Additions/common/VBoxGuestLib

Files:

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibClipboard.cpp

-              r7411
+              r7428
 VBGLR3DECL(int) VbglR3ClipboardConnect(uint32_t *pu32ClientId)
+{
+    VBoxGuestHGCMConnectInfo Info = { 0 };
+    VBoxGuestHGCMConnectInfo Info;
     Info.result = (uint32_t)VERR_WRONG_ORDER; /** @todo drop the cast when the result type has been fixed! */
     Info.Loc.type = VMMDevHGCMLoc_LocalHost_Existing;
     // memset(&Info.Loc.u, 0, sizeof(Info.Loc.u));
+    memset(&Info.Loc.u, 0, sizeof(Info.Loc.u));
     strcpy(Info.Loc.u.host.achName, "VBoxSharedClipboard");
+    Info.u32ClientID = UINT32_MAX;  /* try make valgrid shut up. */
     int rc = vbglR3DoIOCtl(IOCTL_VBOXGUEST_HGCM_CONNECT, &Info, sizeof(Info));
 …
 VBGLR3DECL(int) VbglR3ClipboardGetHostMsg(uint32_t u32ClientId, uint32_t *pMsg, uint32_t *pfFormats)
+{
     VBoxClipboardGetHostMsg Msg = { 0 };
+    VBoxClipboardGetHostMsg Msg;
     Msg.hdr.result = (uint32_t)VERR_WRONG_ORDER;  /** @todo drop the cast when the result type has been fixed! */

-              r7411
+              r7428
 VBGLR3DECL(int) VbglR3SeamlessWaitEvent(VMMDevSeamlessMode *pMode)
+{
     VBoxGuestWaitEventInfo waitEvent = { 0 };
+    VBoxGuestWaitEventInfo waitEvent;
     int rc;
 …
     waitEvent.u32TimeoutIn = RT_INDEFINITE_WAIT;
     waitEvent.u32EventMaskIn = VMMDEV_EVENT_SEAMLESS_MODE_CHANGE_REQUEST;
+    waitEvent.u32Result = VBOXGUEST_WAITEVENT_ERROR;
+    waitEvent.u32EventFlagsOut = 0;
     rc = vbglR3DoIOCtl(VBOXGUEST_IOCTL_WAITEVENT, &waitEvent, sizeof(waitEvent));
     if (RT_SUCCESS(rc))

-              r7411
+              r7428
                                              uint32_t *piDisplay)
+{
     VBoxGuestWaitEventInfo waitEvent = { 0 };
+    VBoxGuestWaitEventInfo waitEvent;
     int rc;
 …
     waitEvent.u32TimeoutIn = RT_INDEFINITE_WAIT;
     waitEvent.u32EventMaskIn = VMMDEV_EVENT_DISPLAY_CHANGE_REQUEST;
+    waitEvent.u32Result = VBOXGUEST_WAITEVENT_ERROR;
+    waitEvent.u32EventFlagsOut = 0;
     rc = vbglR3DoIOCtl(VBOXGUEST_IOCTL_WAITEVENT, &waitEvent, sizeof(waitEvent));
     if (RT_SUCCESS(rc))

Note: See TracChangeset for help on using the changeset viewer.