Changeset 74301 in vbox for trunk

Timestamp:

Sep 17, 2018 4:16:38 AM (6 years ago)

Author:

vboxsync

Message:

VMM/IEM: Nested SVM: bugref:7243 Comment nit.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImplSvmInstr.cpp.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllCImplSvmInstr.cpp.h

@@ -665 +665 @@
          * nested-guest (or the guest).
          *
-         *   - VMCPU_FF_INHIBIT_INTERRUPTS need -not- be preserved as it's for a single
-         *     instruction which is this VMRUN instruction itself.
-         *
          *   - VMCPU_FF_BLOCK_NMIS needs to be preserved as it blocks NMI until the
          *     execution of a subsequent IRET instruction in the guest.
          *
-         *   - The remaining FFs (e.g. timers) can stay in place so that we will be
-         *     able to generate interrupts that should cause #VMEXITs for the
-         *     nested-guest.
+         * The remaining FFs (e.g. timers) can stay in place so that we will be able to
+         * generate interrupts that should cause #VMEXITs for the nested-guest.
+         *
+         * VMRUN has implicit GIF (Global Interrupt Flag) handling, we don't need to
+         * preserve VMCPU_FF_INHIBIT_INTERRUPTS.
          */
         pVCpu->cpum.GstCtx.hwvirt.fLocalForcedActions = pVCpu->fLocalForcedActions & VMCPU_FF_BLOCK_NMIS;