Changeset 74352 in vbox for trunk/src/VBox/Runtime/common/crypto

Timestamp:

Sep 18, 2018 9:50:57 PM (6 years ago)

Author:

vboxsync

Message:

IPRT/cipher: Fixed incorrect assertions. bugref:9246

File:

• trunk/src/VBox/Runtime/common/crypto/cipher-openssl.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/common/crypto/cipher-openssl.cpp

@@ -189 +189 @@
     AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertReturn(pThis->u32Magic == RTCRCIPHERINT_MAGIC, VERR_INVALID_HANDLE);
-    AssertMsgReturn((ssize_t)cbKey != EVP_CIPHER_key_length(pThis->pCipher),
+    AssertMsgReturn((ssize_t)cbKey == EVP_CIPHER_key_length(pThis->pCipher),
                     ("%zu, expected %d\n", cbKey, EVP_CIPHER_key_length(pThis->pCipher)),
                     VERR_CR_CIPHER_INVALID_KEY_LENGTH);
-    AssertMsgReturn((ssize_t)cbInitVector != EVP_CIPHER_iv_length(pThis->pCipher),
+    AssertMsgReturn((ssize_t)cbInitVector == EVP_CIPHER_iv_length(pThis->pCipher),
                     ("%zu, expected %d\n", cbInitVector, EVP_CIPHER_iv_length(pThis->pCipher)),
                     VERR_CR_CIPHER_INVALID_INITIALIZATION_VECTOR_LENGTH);
@@ -273 +273 @@
     AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
     AssertReturn(pThis->u32Magic == RTCRCIPHERINT_MAGIC, VERR_INVALID_HANDLE);
-    AssertMsgReturn((ssize_t)cbKey != EVP_CIPHER_key_length(pThis->pCipher),
+    AssertMsgReturn((ssize_t)cbKey == EVP_CIPHER_key_length(pThis->pCipher),
                     ("%zu, expected %d\n", cbKey, EVP_CIPHER_key_length(pThis->pCipher)),
                     VERR_CR_CIPHER_INVALID_KEY_LENGTH);
-    AssertMsgReturn((ssize_t)cbInitVector != EVP_CIPHER_iv_length(pThis->pCipher),
+    AssertMsgReturn((ssize_t)cbInitVector == EVP_CIPHER_iv_length(pThis->pCipher),
                     ("%zu, expected %d\n", cbInitVector, EVP_CIPHER_iv_length(pThis->pCipher)),
                     VERR_CR_CIPHER_INVALID_INITIALIZATION_VECTOR_LENGTH);