Changeset 74564 in vbox for trunk

Timestamp:

Oct 2, 2018 5:59:22 AM (6 years ago)

Author:

vboxsync

Message:

VMM/IEM: Nested VMX: bugref:9180 Make sure we don't accidentally use the simple version of the instruction VM-exit for
instructions that require figuring out additional VM-exit information.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp.h

@@ -2652 +2652 @@
     ExitInfo.uReason = uExitReason;
     ExitInfo.cbInstr = cbInstr;
+
+#ifdef VBOX_STRICT
+    /* To prevent us from shooting ourselves in the foot. Maybe remove later. */
+    switch (uExitReason)
+    {
+        case VMX_EXIT_INVEPT:
+        case VMX_EXIT_INVPCID:
+        case VMX_EXIT_LDTR_TR_ACCESS:
+        case VMX_EXIT_GDTR_IDTR_ACCESS:
+        case VMX_EXIT_VMCLEAR:
+        case VMX_EXIT_VMPTRLD:
+        case VMX_EXIT_VMPTRST:
+        case VMX_EXIT_VMREAD:
+        case VMX_EXIT_VMWRITE:
+        case VMX_EXIT_VMXON:
+        case VMX_EXIT_XRSTORS:
+        case VMX_EXIT_XSAVES:
+        case VMX_EXIT_RDRAND:
+        case VMX_EXIT_RDSEED:
+        case VMX_EXIT_IO_INSTR:
+            AssertMsgFailedReturn(("Use iemVmxVmexitInstrNeedsInfo for uExitReason=%u\n", uExitReason), VERR_IEM_IPE_5);
+            break;
+    }
+#endif
+
     return iemVmxVmexitInstrWithInfo(pVCpu, &ExitInfo);
 }