Changeset 74790 in vbox for trunk/src/VBox/VMM/VMMRC

Timestamp:

Oct 12, 2018 10:42:58 AM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

125734

Message:

vm.h,VMM: Use VM_FF_IS_SET instead of VM_FF_IS_PENDING when checking a single flag. Added compile time assertion on single flag. bugref:9180

File:

• trunk/src/VBox/VMM/VMMRC/TRPMRCHandlers.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMRC/TRPMRCHandlers.cpp

@@ -184 +184 @@
             TMTimerPollVoid(pVM, pVCpu);
             Log2(("TMTimerPoll at %08RX32 - VM_FF_TM_VIRTUAL_SYNC=%d VM_FF_TM_VIRTUAL_SYNC=%d\n", pRegFrame->eip,
-                  VM_FF_IS_PENDING(pVM, VM_FF_TM_VIRTUAL_SYNC), VMCPU_FF_IS_SET(pVCpu, VMCPU_FF_TIMER)));
+                  VM_FF_IS_SET(pVM, VM_FF_TM_VIRTUAL_SYNC), VMCPU_FF_IS_SET(pVCpu, VMCPU_FF_TIMER)));
         }
     }
@@ -223 +223 @@
     {
         /* The out of memory condition naturally outranks the others. */
-        if (RT_UNLIKELY(VM_FF_IS_PENDING(pVM, VM_FF_PGM_NO_MEMORY)))
+        if (RT_UNLIKELY(VM_FF_IS_SET(pVM, VM_FF_PGM_NO_MEMORY)))
             rc = VINF_EM_NO_MEMORY;
         else
@@ -244 +244 @@
                 rc = VINF_EM_RAW_TIMER_PENDING;
             /* The Virtual Sync clock has stopped. */
-            else if (VM_FF_IS_PENDING(pVM, VM_FF_TM_VIRTUAL_SYNC))
+            else if (VM_FF_IS_SET(pVM, VM_FF_TM_VIRTUAL_SYNC))
                 rc = VINF_EM_RAW_TO_R3;
             /* DMA work pending? */
-            else if (VM_FF_IS_PENDING(pVM, VM_FF_PDM_DMA))
+            else if (VM_FF_IS_SET(pVM, VM_FF_PDM_DMA))
                 rc = VINF_EM_RAW_TO_R3;
             /* Pending request packets might contain actions that need immediate