Changeset 74902 in vbox for trunk

Timestamp:

Oct 18, 2018 6:52:43 AM (6 years ago)

Author:

vboxsync

Message:

VMM/IEM: Nested VMX: bugref:9180 Trying to figure out the relative priority of exits here. The spec is hard to parse.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp.h (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp.h

@@ -4946 +4946 @@
      *
      * See Intel spec. 25.2 "Other Causes Of VM Exits".
+     * See Intel spec. 26.6.5 "Interrupt-Window Exiting and Virtual-Interrupt Delivery".
      */
     PCVMXVVMCS pVmcs = pVCpu->cpum.GstCtx.hwvirt.vmx.CTX_SUFF(pVmcs);
@@ -6090 +6091 @@
                                 pVCpu->cpum.GstCtx.hwvirt.vmx.fInVmxNonRootMode = true;
 
+                                /** The priority of potential VM-exits during VM-entry is important. */
+                                /** @todo NSTVMX: Any debug trap exceptions must be handled here. */
+                                /** @todo NSTVMX: VMX preemption timer exiting. */
+                                /** @todo NSTVMX: TPR thresholding exiting. */
+                                /** @todo NSTVMX: NMI-window exiting. */
+
                                 /* Check premature interrupt-window exiting. */
                                 rc = iemVmxVmentryCheckIntWindowExit(pVCpu, pszInstr);
@@ -6097 +6104 @@
                                     return VINF_SUCCESS;
 
+                                /** @todo NSTVMX: Pending MTF exiting. */
+
                                 /* Now that we've switched page tables, we can inject events if any. */
                                 iemVmxVmentryInjectEvent(pVCpu, pszInstr);
-
-                                /** @todo NSTVMX: Setup VMX preemption timer */
-                                /** @todo NSTVMX: TPR thresholding. */
 
                                 return VINF_SUCCESS;