Changeset 75120 in vbox for trunk

Timestamp:

Oct 26, 2018 8:51:21 PM (6 years ago)

Author:

vboxsync

Message:

DevHDA: Timer description string passed to PDMDevHlpTMTimerCreate shall not be a stack variable. Read the documentation.

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -5213 +5213 @@
          * Create all hardware streams.
          */
+        static const char * const s_apszNames[] =
+        {
+            "HDA SD0", "HDA SD1", "HDA SD2", "HDA SD3",
+            "HDA SD4", "HDA SD5", "HDA SD6", "HDA SD7",
+        };
+        AssertCompile(RT_ELEMENTS(s_apszNames) == HDA_MAX_STREAMS);
         for (uint8_t i = 0; i < HDA_MAX_STREAMS; ++i)
         {
@@ -5221 +5227 @@
              *        instead of the LPIB registers.
              */
-            char szTimer[16];
-            RTStrPrintf2(szTimer, sizeof(szTimer), "HDA SD%RU8", i);
-
             rc = PDMDevHlpTMTimerCreate(pDevIns, TMCLOCK_VIRTUAL_SYNC, hdaR3Timer, &pThis->aStreams[i],
-                                        TMTIMER_FLAGS_NO_CRIT_SECT, szTimer, &pThis->pTimer[i]);
+                                        TMTIMER_FLAGS_NO_CRIT_SECT, s_apszNames[i], &pThis->pTimer[i]);
             AssertRCReturn(rc, rc);