Changeset 75144 in vbox for trunk/src

Timestamp:

Oct 29, 2018 1:10:42 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

126222

Message:

FE/Qt: bugref:9241: VirtualBox Manager: Forgot that r126142 requires a bit of caching work from UIToolPaneMachine side.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIToolPaneMachine.cpp (modified) (6 diffs)
• UIToolPaneMachine.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIToolPaneMachine.cpp

@@ -124 +124 @@
                     connect(this, &UIToolPaneMachine::sigToggleFinished, m_pPaneDetails, &UIDetails::sigToggleFinished);
                     connect(m_pPaneDetails, &UIDetails::sigLinkClicked,  this, &UIToolPaneMachine::sigLinkClicked);
+                    m_pPaneDetails->setItems(m_items);
 
                     /* Add into layout: */
@@ -146 +147 @@
                     connect(m_pPaneSnapshots, &UISnapshotPane::sigCurrentItemChange,
                             this, &UIToolPaneMachine::sigCurrentSnapshotItemChange);
+                    m_pPaneSnapshots->setMachine(m_comMachine);
 
                     /* Add into layout: */
@@ -166 +168 @@
                     /* Configure pane: */
                     m_pPaneLogViewer->setProperty("ToolType", QVariant::fromValue(UIToolType_Logs));
+                    m_pPaneLogViewer->setMachine(m_comMachine);
 
                     /* Add into layout: */
@@ -224 +227 @@
 void UIToolPaneMachine::setItems(const QList<UIVirtualMachineItem*> &items)
 {
+    /* Cache passed value: */
+    m_items = items;
+
     /* Update details pane is it is open: */
     if (isToolOpened(UIToolType_Details))
     {
         AssertPtrReturnVoid(m_pPaneDetails);
-        m_pPaneDetails->setItems(items);
+        m_pPaneDetails->setItems(m_items);
     }
 }
@@ -234 +240 @@
 void UIToolPaneMachine::setMachine(const CMachine &comMachine)
 {
+    /* Cache passed value: */
+    m_comMachine = comMachine;
+
     /* Update snapshots pane is it is open: */
     if (isToolOpened(UIToolType_Snapshots))
     {
         AssertPtrReturnVoid(m_pPaneSnapshots);
-        m_pPaneSnapshots->setMachine(comMachine);
+        m_pPaneSnapshots->setMachine(m_comMachine);
     }
     /* Update logviewer pane is it is open: */
@@ -244 +253 @@
     {
         AssertPtrReturnVoid(m_pPaneLogViewer);
-        m_pPaneLogViewer->setMachine(comMachine);
+        m_pPaneLogViewer->setMachine(m_comMachine);
     }
 }

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIToolPaneMachine.h

@@ -25 +25 @@
 #include "UIExtraDataDefs.h"
 
+/* COM includes: */
+#include "COMEnums.h"
+#include "CMachine.h"
+
 /* Forward declarations: */
 class QHBoxLayout;
@@ -35 +39 @@
 class UIVirtualMachineItem;
 class UIVMLogViewerWidget;
-class CMachine;
 
 
@@ -113 +116 @@
     /** Holds the Logviewer pane instance. */
     UIVMLogViewerWidget *m_pPaneLogViewer;
+
+    /** Holds the cache of passed items. */
+    QList<UIVirtualMachineItem*>  m_items;
+    /** Holds the cache of passed machine. */
+    CMachine                      m_comMachine;
 };