Changeset 75244 in vbox for trunk/src/VBox/Runtime/common

Timestamp:

Nov 3, 2018 3:05:11 AM (6 years ago)

Author:

vboxsync

Message:

IPRT/rtDbgModCvLoadDirectory: Added note about what seems to be wlink trashing the directory header. I think I've wasted time debugging this once before, hope the comments will prevent a 3rd time. :-)

File:

• trunk/src/VBox/Runtime/common/dbg/dbgmodcodeview.cpp (modified) (5 diffs)

trunk/src/VBox/Runtime/common/dbg/dbgmodcodeview.cpp

@@ -1750 +1750 @@
         /*
          * 32-bit type (reading too much for NB04 is no problem).
+         *
+         * Note! The watcom linker (v1.9) seems to overwrite the directory
+         *       header and more under some conditions.  So, if this code fails
+         *       you might be so lucky as to have reproduce that issue...
          */
         RTCVDIRHDR32EX DirHdr;
@@ -1758 +1762 @@
                 && DirHdr.Core.cbHdr != sizeof(DirHdr))
             {
-                Log(("Unexpected CV directory size: %#x\n", DirHdr.Core.cbHdr));
+                Log(("Unexpected CV directory size: %#x [wlink screwup?]\n", DirHdr.Core.cbHdr));
                 rc = VERR_CV_BAD_FORMAT;
             }
@@ -1765 +1769 @@
                     || DirHdr.fFlags     != 0) )
             {
-                Log(("Extended CV directory headers fields are not zero: fFlags=%#x offNextDir=%#x\n",
+                Log(("Extended CV directory headers fields are not zero: fFlags=%#x offNextDir=%#x [wlink screwup?]\n",
                      DirHdr.fFlags, DirHdr.offNextDir));
                 rc = VERR_CV_BAD_FORMAT;
@@ -1771 +1775 @@
             if (DirHdr.Core.cbEntry != sizeof(RTCVDIRENT32))
             {
-                Log(("Unexpected CV directory entry size: %#x (expected %#x)\n", DirHdr.Core.cbEntry, sizeof(RTCVDIRENT32)));
+                Log(("Unexpected CV directory entry size: %#x (expected %#x) [wlink screwup?]\n", DirHdr.Core.cbEntry, sizeof(RTCVDIRENT32)));
                 rc = VERR_CV_BAD_FORMAT;
             }
             if (DirHdr.Core.cEntries < 2 || DirHdr.Core.cEntries >= _512K)
             {
-                Log(("CV directory count is out of considered valid range: %#x\n", DirHdr.Core.cEntries));
+                Log(("CV directory count is out of considered valid range: %#x [wlink screwup?]\n", DirHdr.Core.cEntries));
                 rc = VERR_CV_BAD_FORMAT;
             }
@@ -2882 +2886 @@
         if (pCvHdr->off < cb && pCvHdr->off >= sizeof(*pCvHdr))
         {
-            Log(("RTDbgModCv: Found %c%c%c%c at %#RTfoff - size %#x, directory at %#x. file type %d\n",
+            Log(("RTDbgModCv: Found %c%c%c%c at %#x - size %#x, directory at %#x. file type %d\n",
                  RT_BYTE1(pCvHdr->u32Magic), RT_BYTE2(pCvHdr->u32Magic), RT_BYTE3(pCvHdr->u32Magic), RT_BYTE4(pCvHdr->u32Magic),
                  off, cb, pCvHdr->off, enmFileType));