Changeset 75533 in vbox for trunk/include

Timestamp:

Nov 17, 2018 12:16:33 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

126691

Message:

VMMDev.h: Reduce the VMMDEV_MAX_HGCM_PARMS and VMMDEV_MAX_HGCM_DATA_SIZE values to something more sane.

File:

• trunk/include/VBox/VMMDev.h (modified) (1 diff)

trunk/include/VBox/VMMDev.h

@@ -88 +88 @@
 #define VMMDEV_MAX_VMMDEVREQ_SIZE           _1M
 /** Maximum number of HGCM parameters.
- * @todo r=bird: This is wrong wrt user land calls. For them it iss 61.
+ * @note This used to be 1024, which is kind of insane.  Was changed to 32,
+ *       given that (guest) user land can only pass 61 anyway.
  *       See comments on VBGLIOCHGCMCALL::cParms. */
-#define VMMDEV_MAX_HGCM_PARMS               1024
-/** Maximum total size of hgcm buffers in one call. */
-#define VMMDEV_MAX_HGCM_DATA_SIZE           UINT32_C(0x7FFFFFFF)
+#define VMMDEV_MAX_HGCM_PARMS               32
+/** Maximum total size of hgcm buffers in one call.
+ * @note Used to be 2G, since reduced to 128MB.  */
+#define VMMDEV_MAX_HGCM_DATA_SIZE           _128M
 
 /**