Changeset 75538 in vbox for trunk/src/VBox/Devices

Timestamp:

Nov 17, 2018 2:32:21 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

126696

Message:

VMMDev/HGCM: Use an allocation cache for HGCM command structures with 6 or fewer parameters (also connect and disconnect). Moved the connection location out of the union just like the parameters, as it's 132 bytes big. bugref:9172 [destroy fix]

File:

• trunk/src/VBox/Devices/VMMDev/VMMDevHGCM.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/VMMDev/VMMDevHGCM.cpp

@@ -2163 +2163 @@
     LogFlowFunc(("\n"));
 
-    RTCritSectDelete(&pThis->critsectHGCMCmdList);
-
-    PVBOXHGCMCMD pCmd, pNext;
-    RTListForEachSafe(&pThis->listHGCMCmd, pCmd, pNext, VBOXHGCMCMD, node)
-    {
-        vmmdevHGCMRemoveCommand(pThis, pCmd);
-        vmmdevHGCMCmdFree(pThis, pCmd);
+    if (RTCritSectIsInitialized(&pThis->critsectHGCMCmdList))
+    {
+        PVBOXHGCMCMD pCmd, pNext;
+        RTListForEachSafe(&pThis->listHGCMCmd, pCmd, pNext, VBOXHGCMCMD, node)
+        {
+            vmmdevHGCMRemoveCommand(pThis, pCmd);
+            vmmdevHGCMCmdFree(pThis, pCmd);
+        }
+
+        RTCritSectDelete(&pThis->critsectHGCMCmdList);
     }
 
@@ -2191 +2194 @@
 int vmmdevHGCMInit(PVMMDEV pThis)
 {
+    LogFlowFunc(("\n"));
+
     RTListInit(&pThis->listHGCMCmd);