Changeset 75572 in vbox for trunk/src/VBox/Frontends

Timestamp:

Nov 19, 2018 12:27:02 PM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9104: UIUpdateManager: Use UIVersion stuff to compare ext-pack and vbox versions.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/net/UIUpdateManager.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/net/UIUpdateManager.cpp

@@ -427 +427 @@
     /* Get extension pack version: */
     QString strExtPackVersion(extPack.GetVersion());
-    QByteArray abExtPackVersion = strExtPackVersion.toUtf8();
 
     /* If this version being developed: */
@@ -446 +445 @@
     const QString strVBoxVersion = vboxVersion.toString();
 
-    /* Skip the check if the extension pack is equal to or newer than VBox.
-     * Note! Use RTStrVersionCompare for the comparison here as it takes the
-     *       beta/alpha/preview/whatever tags into consideration when comparing versions. */
-    if (RTStrVersionCompare(abExtPackVersion.constData(), strVBoxVersion.toUtf8().constData()) >= 0)
+    /* Skip the check if the extension pack is equal to or newer than VBox. */
+    if (UIVersion(strExtPackVersion) >= vboxVersion)
     {
         emit sigStepComplete();