Changeset 75601 in vbox for trunk/src/VBox/Main

Timestamp:

Nov 19, 2018 9:22:15 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

126771

Message:

Main/HGCMThread: Use an automatic reset event semaphore rather an manual reset one. Saves a kernel call per message. bugref:9172

File:

• trunk/src/VBox/Main/src-client/HGCMThread.cpp (modified) (8 diffs)

trunk/src/VBox/Main/src-client/HGCMThread.cpp

@@ -85 +85 @@
         RTTHREAD m_hThread;
 
-        /* Event the thread waits for, signalled when a message
-         * to process is posted to the thread.
-         */
-        RTSEMEVENTMULTI m_eventThread;
+        /** Event the thread waits for, signalled when a message to process is posted to
+         * the thread, automatically reset. */
+        RTSEMEVENT m_eventThread;
 
         /* A caller thread waits for completion of a SENT message on this event. */
@@ -216 +215 @@
     m_pvUser(NULL),
     m_hThread(NIL_RTTHREAD),
-    m_eventThread(NIL_RTSEMEVENTMULTI),
+    m_eventThread(NIL_RTSEMEVENT),
     m_eventSend(NIL_RTSEMEVENTMULTI),
     m_i32MessagesProcessed(0),
@@ -247 +246 @@
     }
 
-    if (m_eventThread != NIL_RTSEMEVENTMULTI)
-    {
-        RTSemEventMultiDestroy(m_eventThread);
-        m_eventThread = NIL_RTSEMEVENTMULTI;
+    if (m_eventThread != NIL_RTSEMEVENT)
+    {
+        RTSemEventDestroy(m_eventThread);
+        m_eventThread = NIL_RTSEMEVENT;
     }
 }
@@ -268 +267 @@
 int HGCMThread::Initialize(const char *pszThreadName, PFNHGCMTHREAD pfnThread, void *pvUser, const char *pszStatsSubDir, PUVM pUVM)
 {
-    int rc = RTSemEventMultiCreate(&m_eventThread);
+    int rc = RTSemEventCreate(&m_eventThread);
 
     if (RT_SUCCESS(rc))
@@ -340 +339 @@
     {
         Log(("hgcmThreadCreate: FAILURE: Can't create an event semaphore for a hgcm worker thread.\n"));
-        m_eventThread = NIL_RTSEMEVENTMULTI;
+        m_eventThread = NIL_RTSEMEVENT;
     }
 
@@ -443 +442 @@
 
         /* Inform the worker thread that there is a message. */
-        RTSemEventMultiSignal(m_eventThread);
+        RTSemEventSignal(m_eventThread);
 
         LogFlow(("HGCMThread::MsgPost: event signalled\n"));
@@ -453 +452 @@
             {
                 /* Poll infrequently to make sure no completed message has been missed. */
-                RTSemEventMultiWait (m_eventSend, 1000);
+                RTSemEventMultiWait(m_eventSend, 1000);
 
                 LogFlow(("HGCMThread::MsgPost: wait completed flags = %08X\n", pMsg->m_fu32Flags));
@@ -548 +547 @@
 
         /* Wait for an event. */
-        RTSemEventMultiWait (m_eventThread, RT_INDEFINITE_WAIT);
-        RTSemEventMultiReset (m_eventThread);
+        RTSemEventWait(m_eventThread, RT_INDEFINITE_WAIT);
     }