Changeset 75727 in vbox

Timestamp:

Nov 26, 2018 8:39:43 AM (6 years ago)

Author:

vboxsync

Message:

VBoxServiceControlSession.cpp: Bail out in vgsvcGstCtrlSessionSpawnWorker() when we're unable to connect to the host service.

File:

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp

-              r75720
+              r75727
+    }
     else
+/** @todo r=bird: This should return to caller, shouldn't it it?!?
+ * Because VbglR3GuestCtrlSessionNotify() below is now using an uninitialized
+ * uClientID, right?  If you check VbglR3GuestCtrlConnect, you can clearly see
+ * that it will not be set, except on success.  So, this is a terrible idea!
+ *
+ * Did this happen because of a weird desire to have a single return statement?
+ * Or was it some other confusion wrt program flow/state?  Indentation fright?
+ * Please figure out why and try not to do it again. :-)
+ */
+    {
         VGSvcError("Error connecting to guest control service, rc=%Rrc\n", rc);
+        return RTEXITCODE_FAILURE;
+    }
     /* Report started status. */

Note: See TracChangeset for help on using the changeset viewer.