Changeset 75730 in vbox for trunk/src/VBox/Main/src-server

Timestamp:

Nov 26, 2018 10:57:56 AM (6 years ago)

Author:

vboxsync

Message:

Main/CloudProviderManager: Make sure to keep cloud providers implementing the expected interface only, i.e. drop anything which VBoxSVC doesn't know how to use.

File:

• trunk/src/VBox/Main/src-server/CloudProviderManagerImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/CloudProviderManagerImpl.cpp

@@ -164 +164 @@
     for (unsigned i = 0; i < apProvidersFromCurrExtPack.size(); i++)
     {
-        Assert(m_astrExtPackNames.size() == m_apCloudProviders.size());
-        m_astrExtPackNames.push_back(strName);
-        m_apCloudProviders.push_back(apProvidersFromCurrExtPack[i]);
+        // Sanity check each cloud provider by forcing a QueryInterface call,
+        // making sure that it implements the right interface.
+        ComPtr<ICloudProvider> pTmpCP1(apProvidersFromCurrExtPack[i]);
+        if (!pTmpCP1.isNull())
+        {
+            ComPtr<ICloudProvider> pTmpCP2;
+            pTmpCP1.queryInterfaceTo(pTmpCP2.asOutParam());
+            if (!pTmpCP2.isNull())
+            {
+                Assert(m_astrExtPackNames.size() == m_apCloudProviders.size());
+                m_astrExtPackNames.push_back(strName);
+                m_apCloudProviders.push_back(apProvidersFromCurrExtPack[i]);
+            }
+        }
     }
 }