Changeset 75737 in vbox for trunk/src/VBox/HostServices/GuestControl/testcase

Timestamp:

Nov 26, 2018 3:44:41 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

126937

Message:

HGCM: Replace C++-style inline members on VBOXHGCMSVCPARM with simple functions.
bugref:9172: Shared folder performance tuning
Changes in bugref:9172 caused a build regression on Ubuntu 18.10 due to the
use of RT_ZERO on a structure containing an embedded VBOXHGCMSVCPARM, as
VBOXHGCMSVCPARM had member functions and was therefore not a simple plain-
old-data structure. Rather than just doing the sensible thing and zeroing
it in a different way, I converted the inline member getters and setters to
standard inline C functions, including fixing callers. Actually I had planned
this for some time, as the member function use seemed a bit gratuitous in
hindsight.

File:

• trunk/src/VBox/HostServices/GuestControl/testcase/tstGuestControlSvc.cpp (modified) (3 diffs)

trunk/src/VBox/HostServices/GuestControl/testcase/tstGuestControlSvc.cpp

@@ -152 +152 @@
 
     VBOXHGCMSVCPARM aParms[1];
-    aParms[0].setUInt32(1000 /* Context ID */);
+    HGCMSvcSetU32(&aParms[0], 1000 /* Context ID */);
 
     CMDHOST aCmdHostAll[] =
@@ -208 +208 @@
         /* No commands from host yet. */
         VBOXHGCMSVCPARM aParmsGuest[8];
-        aParmsGuest[0].setUInt32(0 /* Msg type */);
-        aParmsGuest[1].setUInt32(0 /* Parameters */);
+        HGCMSvcSetU32(&aParmsGuest[0], 0 /* Msg type */);
+        HGCMSvcSetU32(&aParmsGuest[1], 0 /* Parameters */);
         pTable->pfnCall(pTable->pvService, &callHandle, 1 /* Client ID */, NULL /* pvClient */,
                         GUEST_MSG_WAIT, 2, &aParmsGuest[0], 0);
@@ -216 +216 @@
         /* Host: Add a dummy command. */
         VBOXHGCMSVCPARM aParmsHost[8];
-        aParmsHost[0].setUInt32(1000 /* Context ID */);
-        aParmsHost[1].setString("foo.bar");
-        aParmsHost[2].setString("baz");
+        HGCMSvcSetU32(&aParmsHost[0], 1000 /* Context ID */);
+        HGCMSvcSetStr(&aParmsHost[1], "foo.bar");
+        HGCMSvcSetStr(&aParmsHost[2], "baz");
 
         rc = pTable->pfnHostCall(pTable->pvService, HOST_EXEC_CMD, 3, &aParmsHost[0]);