Changeset 75737 in vbox for trunk/src/VBox/Main/include

Timestamp:

Nov 26, 2018 3:44:41 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

126937

Message:

HGCM: Replace C++-style inline members on VBOXHGCMSVCPARM with simple functions.
bugref:9172: Shared folder performance tuning
Changes in bugref:9172 caused a build regression on Ubuntu 18.10 due to the
use of RT_ZERO on a structure containing an embedded VBOXHGCMSVCPARM, as
VBOXHGCMSVCPARM had member functions and was therefore not a simple plain-
old-data structure. Rather than just doing the sensible thing and zeroing
it in a different way, I converted the inline member getters and setters to
standard inline C functions, including fixing callers. Actually I had planned
this for some time, as the member function use seemed a bit gratuitous in
hindsight.

File:

• trunk/src/VBox/Main/include/GuestDnDPrivate.h (modified) (4 diffs)

trunk/src/VBox/Main/include/GuestDnDPrivate.h

@@ -887 +887 @@
         }
 
-        pParm->setPointer(pvTmp, cbBuf);
+        HGCMSvcSetPv(pParm, pvTmp, cbBuf);
         return VINF_SUCCESS;
     }
@@ -901 +901 @@
             return VERR_NO_MEMORY;
 
-        pParm->setString(pszTemp);
+        HGCMSvcSetStr(pParm, pszTemp);
         return VINF_SUCCESS;
     }
@@ -911 +911 @@
             return VERR_NO_MEMORY;
 
-        pParm->setUInt32(u32Val);
+        HGCMSvcSetU32(pParm, u32Val);
         return VINF_SUCCESS;
     }
@@ -921 +921 @@
             return VERR_NO_MEMORY;
 
-        pParm->setUInt64(u64Val);
+        HGCMSvcSetU64(pParm, u64Val);
         return VINF_SUCCESS;
     }