Changeset 75832 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Nov 30, 2018 9:36:07 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

127035

Message:

VBoxManage/guestcontrol: r=bird comments

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -219 +219 @@
             AssertPtrReturn(pszPath, VERR_INVALID_POINTER);
 
+/** @todo r=bird: Do ONE RTPathQueryInfo call here, and only do it when the source is on the HOST.
+ * You're currently doing this for guest files too...
+ *
+ * You realize that a filter is a filter when you define it to be, not when the
+ * file doesn't exist.  It something the command defines, nothing else. So, it
+ * makes not sense. */
             if (   !RTFileExists(pszPath)
                 && !RTDirExists(pszPath))
@@ -1777 +1783 @@
 
             case VINF_GETOPT_NOT_OPTION:
-                /* Last argument and no destination specified with
-                 * --target-directory yet? Then use the current
-                 * (= last) argument as destination. */
+                /* Last argument and no destination specified with --target-directory yet?
+                   Then use the current (= last) argument as destination. */
                 if (   GetState.argc == GetState.iNext
                     && pszDst == NULL)
@@ -1787 +1792 @@
                     try
                     {   /* Save the source directory. */
+/** @todo r=bird: Why the fudge do you do two 'ing stat() calls on the HOST when copy files from the GUEST?
+ * Guess it is just some stuff that happened while you were working on SOURCEFILEENTRY, but it doesn't make
+ * it more sensible.
+ */
                         vecSources.push_back(SOURCEFILEENTRY(ValueUnion.psz));
                     }