Changeset 75862 in vbox

Timestamp:

Dec 2, 2018 12:33:01 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

127066

Message:

Main/Guest: Added a few codereview comments, mainly in the guest base class area. Replaced the object ID management in GuestSession with a classic allocation bitmap approach as that's much less memory intensive than 16 byte structs in a insert-only std::map and an additional map tracking free 32-bit IDs after we run out. bugref:9313 [build fix]

File:

• trunk/src/VBox/Main/src-client/GuestCtrlImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/GuestCtrlImpl.cpp

@@ -161 +161 @@
 
 #ifdef DEBUG
-        bool fDispatch = true;
         /*
          * Pre-check: If we got a status message with an error and VERR_TOO_MUCH_DATA
@@ -169 +168 @@
          *            this further because we don't have a valid context ID.
          */
+        bool fDispatch = true;
         if (   pCtxCb->uFunction == GUEST_EXEC_STATUS
             && pSvcCb->mParms    >= 5)
@@ -183 +183 @@
             {
                 LogFlowFunc(("Requested command with too much data, skipping dispatching ...\n"));
-
                 Assert(dataCb.uPID == 0);
                 fDispatch = false;
+                rc = VINF_SUCCESS;
             }
         }