Changeset 75865 in vbox

Timestamp:

Dec 2, 2018 1:27:29 AM (6 years ago)

Author:

vboxsync

Message:

DevHDA: Fix for crash saving circular stream buffers. [comment updates]

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -3636 +3636 @@
         RTCircBufAcquireReadBlock(pStream->State.pCircBuf, cbCircBufUsed, &pvBuf, &cbBuf);
 #if 0 /** @todo r=bird: The disabled code crashes on me. The #else case contains something that seems
-       * to make more sense to me.  I'm not say this is correct code.  Please review, fix, and remove. */
+       * to make more sense to me.  I'm not saying this is necessarily correct, so please review, fix, and remove. */
 
         if (cbBuf)
@@ -3661 +3661 @@
             }
         }
+
 #else
         Assert(cbBuf);
@@ -3667 +3668 @@
             rc = SSMR3PutMem(pSSM, (uint8_t *)pvBuf - offBuf, cbCircBufUsed - cbBuf);
 #endif
-
         RTCircBufReleaseReadBlock(pStream->State.pCircBuf, 0 /* Don't advance read pointer -- see comment above */);
     }