Changeset 75868 in vbox for trunk/src/VBox/Main/src-client

Timestamp:

Dec 2, 2018 1:34:54 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

127072

Message:

Main/Guest: Added a few codereview comments, mainly in the guest base class area. Replaced the object ID management in GuestSession with a classic allocation bitmap approach as that's much less memory intensive than 16 byte structs in a insert-only std::map and an additional map tracking free 32-bit IDs after we run out. bugref:9313 [build fix]

File:

• trunk/src/VBox/Main/src-client/GuestSessionImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/GuestSessionImpl.cpp

@@ -2103 +2103 @@
     AssertMsgStmt(ASMBitTestAndClear(&mData.bmObjectIds, idObject), ("idObject=%#x\n", idObject), rc = VERR_NOT_FOUND);
 
-    SessionObjects::const_iterator ItObj = mData.mObjects.find(idObject);
+    SessionObjects::iterator ItObj = mData.mObjects.find(idObject);
     AssertMsgReturn(ItObj != mData.mObjects.end(), ("idObject=%#x\n", idObject), VERR_NOT_FOUND);
     mData.mObjects.erase(ItObj);