Changeset 75938 in vbox

Timestamp:

Dec 4, 2018 8:42:19 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

127147

Message:

FE/Qt: bugref:9309: Windows host: Filter out rare duplicated mouse events on the border of endless movement triggers.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/runtime

Files:

• UIMouseHandler.cpp (modified) (3 diffs)
• UIMouseHandler.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMouseHandler.cpp

@@ -527 +527 @@
     , m_iLastMouseWheelDelta(0)
     , m_iMouseCaptureViewIndex(-1)
+#ifdef VBOX_WS_WIN
+    , m_fCursorPositionReseted(false)
+#endif
 {
     /* Machine state-change updater: */
@@ -948 +951 @@
         ::UpdateWindow((HWND)m_viewports[uScreenId]->winId());
 #endif
+
+#ifdef VBOX_WS_WIN
+        // WORKAROUND:
+        // There are situations at least on Windows host that we are receiving
+        // previously posted (but not yet handled) mouse event right after we
+        // have manually teleported mouse cursor to simulate infinite movement,
+        // this makes cursor blink for a large amount of space, so we should
+        // ignore such blinks .. well, at least once.
+        const QPoint shiftingSpace = globalPos - m_lastMousePos;
+        if (m_fCursorPositionReseted && shiftingSpace.manhattanLength() >= 10)
+        {
+            m_fCursorPositionReseted = false;
+            return true;
+        }
+#endif
+
+        /* Pass event to the guest: */
         mouse().PutMouseEvent(globalPos.x() - m_lastMousePos.x(),
                               globalPos.y() - m_lastMousePos.y(),
@@ -986 +1006 @@
             QCursor::setPos(requiredMousePos / dDprPrimary);
             m_lastMousePos = requiredMousePos / dDprCurrent;
+            m_fCursorPositionReseted = true;
         }
         else
+        {
             m_lastMousePos = globalPos;
+            m_fCursorPositionReseted = false;
+        }
 #else /* VBOX_WS_WIN */
         int iWe = gpDesktop->overallDesktopWidth() - 1;

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMouseHandler.h

@@ -139 +139 @@
     int m_iLastMouseWheelDelta;
     int m_iMouseCaptureViewIndex;
+
+#ifdef VBOX_WS_WIN
+    /** Holds whether cursor position was just
+      * reseted to simulate infinite mouse moving. */
+    bool m_fCursorPositionReseted;
+#endif
 };