Changeset 75957 in vbox for trunk/src/VBox/VMM

Timestamp:

Dec 5, 2018 8:06:38 AM (6 years ago)

Author:

vboxsync

Message:

VMM: Nested VMX: bugref:9180 Added APIC-write emulation VM-exit and enabled NMI delivery in the ring-3 EM loop.

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAll.cpp (modified) (2 diffs)
• VMMR3/EM.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAll.cpp

@@ -15716 +15716 @@
 
 /**
- * Interface for HM and EM to perform a APIC-write emulation.
+ * Interface for HM and EM to perform an APIC-write emulation which may cause a
+ * VM-exit.
  *
  * @returns Strict VBox status code.
@@ -15722 +15723 @@
  * @thread  EMT(pVCpu)
  */
-VMM_INT_DECL(VBOXSTRICTRC) IEMExecVmxVirtApicWriteEmulation(PVMCPU pVCpu)
+VMM_INT_DECL(VBOXSTRICTRC) IEMExecVmxVmexitApicWrite(PVMCPU pVCpu)
 {
     IEM_CTX_ASSERT(pVCpu, IEM_CPUMCTX_EXTRN_VMX_VMEXIT_MASK);

trunk/src/VBox/VMM/VMMR3/EM.cpp

@@ -2111 +2111 @@
         }
 
-        /* SMIs take priority over if we ever support them will have to be injected here. */
+#ifdef VBOX_WITH_NESTED_HWVIRT_VMX
+        /*
+         * VMX Nested-guest APIC-write VM-exit.
+         * Takes priority over SMI, INIT signals.
+         * See Intel spec. 29.4.3.2 "APIC-Write Emulation".
+         */
+        if (VMCPU_FF_IS_SET(pVCpu, VMCPU_FF_VMX_APIC_WRITE))
+        {
+            rc2 = VBOXSTRICTRC_VAL(IEMExecVmxVmexitApicWrite(pVCpu));
+            if (rc2 != VINF_VMX_INTERCEPT_NOT_ACTIVE)
+                UPDATE_RC();
+        }
+#endif
+
+        /** @todo SMIs. If we implement SMIs, this is where they will have to be
+         *        delivered. */
 
 #ifdef VBOX_WITH_NESTED_HWVIRT_VMX
@@ -2138 +2153 @@
 #endif
 
-        /** @todo Enable when I get time to test this specific code path later. */
-#if 0
         /*
          * NMIs.
@@ -2162 +2175 @@
                 }
             }
-        }
-#endif
+            UPDATE_RC();
+        }
 
         /*
          * Interrupts.
          */
-        bool fWakeupPending = false;
         if (   !VM_FF_IS_SET(pVM, VM_FF_PGM_NO_MEMORY)
             && (!rc || rc >= VINF_EM_RESCHEDULE_HM)