Changeset 76057 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Dec 7, 2018 1:30:19 PM (6 years ago)

Author:

vboxsync

Message:

Audio/HDA: Removed debug assertions which are not needed anymore in hdaR3SaveStream().

File:

• trunk/src/VBox/Devices/Audio/DevHDA.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DevHDA.cpp

@@ -3505 +3505 @@
 {
     RT_NOREF(pDevIns);
-#if defined(VBOX_STRICT) || defined(LOG_ENABLED)
+#if defined(LOG_ENABLED)
     PHDASTATE pThis = PDMINS_2_DATA(pDevIns, PHDASTATE);
 #endif
@@ -3519 +3519 @@
     AssertRCReturn(rc, rc);
 
-#ifdef VBOX_STRICT
-    uint64_t u64BaseDMA = RT_MAKE_U64(HDA_STREAM_REG(pThis, BDPL, pStream->u8SD),
-                                      HDA_STREAM_REG(pThis, BDPU, pStream->u8SD));
-    uint16_t u16LVI     = HDA_STREAM_REG(pThis, LVI, pStream->u8SD);
-    uint32_t u32CBL     = HDA_STREAM_REG(pThis, CBL, pStream->u8SD);
-
-    Assert(u64BaseDMA == pStream->u64BDLBase);
-    Assert(u16LVI     == pStream->u16LVI);
-    Assert(u32CBL     == pStream->u32CBL);
-#endif
-
     rc = SSMR3PutStructEx(pSSM, &pStream->State.BDLE.Desc, sizeof(HDABDLEDESC),
                           0 /*fFlags*/, g_aSSMBDLEDescFields7, NULL);
@@ -3541 +3530 @@
                           0 /* fFlags */, g_aSSMStreamPeriodFields7, NULL);
     AssertRCReturn(rc, rc);
-
-#ifdef VBOX_STRICT /* Sanity checks. */
-    PHDABDLE pBDLE = &pStream->State.BDLE;
-    if (u64BaseDMA)
-    {
-        Assert(pStream->State.uCurBDLE <= u16LVI + 1);
-
-        HDABDLE curBDLE;
-        rc = hdaR3BDLEFetch(pThis, &curBDLE, u64BaseDMA, pStream->State.uCurBDLE);
-        AssertRC(rc);
-
-        Assert(curBDLE.Desc.u32BufSize == pBDLE->Desc.u32BufSize);
-        Assert(curBDLE.Desc.u64BufAddr  == pBDLE->Desc.u64BufAddr);
-        Assert(curBDLE.Desc.fFlags     == pBDLE->Desc.fFlags);
-    }
-    else
-    {
-        Assert(pBDLE->Desc.u64BufAddr  == 0);
-        Assert(pBDLE->Desc.u32BufSize == 0);
-    }
-#endif
 
     uint32_t cbCircBufSize = 0;