Changeset 7630 in vbox

Timestamp:

Mar 28, 2008 4:32:37 PM (17 years ago)

Author:

vboxsync

Message:

Keep hitting the assertion in the wait code. Attempt to improve this by avoiding calling RTTimeMilliTS twice (RT_MAX() promise double eval of the winner) and force signed math.

File:

• trunk/src/VBox/Devices/Storage/DevATA.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -5278 +5278 @@
             /* Wait for at most 5 seconds, and if that is elapsed for 100msec
              * per remaining thread. Just to be on the safe side. */
+            int64_t cMsElapsed = RTTimeMilliTS() - u64Start;
             rc = RTThreadWait(pData->aCts[i].AsyncIOThread,
-                              RT_MAX(RTTimeMilliTS() - u64Start + 5000, 100),
+                              RT_MAX(cMsElapsed + 5000, 100),
                               NULL);
             if (VBOX_FAILURE(rc) && rc != VERR_INVALID_HANDLE)