Changeset 76681 in vbox

Timestamp:

Jan 7, 2019 3:55:32 PM (6 years ago)

Author:

vboxsync

Message:

USB: Teardown the I/O thread and sync request queue during detach to prevent the I/O thread from accessing the roothub member which was cleared already [fix, move the destruction a bit further down to allow cancelling the URBs]

File:

• trunk/src/VBox/Devices/USB/VUSBDevice.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/USB/VUSBDevice.cpp

@@ -1236 +1236 @@
         pRh->pDefaultAddress = NULL;
 
+    pDev->pHub->pOps->pfnDetach(pDev->pHub, pDev);
+    pDev->i16Port = -1;
+
     /*
      * Destroy I/O thread and request queue last because they might still be used
@@ -1246 +1249 @@
     pDev->hReqQueueSync = NIL_RTREQQUEUE;
 
-    pDev->pHub->pOps->pfnDetach(pDev->pHub, pDev);
-    pDev->i16Port = -1;
     vusbDevSetState(pDev, VUSB_DEVICE_STATE_DETACHED);
     pDev->pHub = NULL;