Changeset 76701 in vbox for trunk

Timestamp:

Jan 8, 2019 11:07:10 AM (6 years ago)

Author:

vboxsync

Message:

Audio/AC97: Moved setting the Hz rate / scheduling hint a bit more to the top so that it actually gets set when creating a stream.

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -2023 +2023 @@
                 Assert(Cfg.enmDir != PDMAUDIODIR_UNKNOWN);
 
-                if (pStream->State.pCircBuf)
-                {
-                    RTCircBufDestroy(pStream->State.pCircBuf);
-                    pStream->State.pCircBuf = NULL;
-                }
-
-                rc = RTCircBufCreate(&pStream->State.pCircBuf, DrvAudioHlpMilliToBytes(100 /* ms */, &Cfg.Props)); /** @todo Make this configurable. */
-                if (RT_SUCCESS(rc))
-                {
-                    ichac97R3MixerRemoveDrvStreams(pThis, pMixSink, Cfg.enmDir, Cfg.DestSource);
-
-                    rc = ichac97R3MixerAddDrvStreams(pThis, pMixSink, &Cfg);
-                    if (RT_SUCCESS(rc))
-                        rc = DrvAudioHlpStreamCfgCopy(&pStream->State.Cfg, &Cfg);
-                }
-
                 /*
                  * Set the stream's timer Hz rate, based on the PCM properties Hz rate.
@@ -2055 +2039 @@
                 if (pStream->State.uTimerHz)
                     Cfg.Device.uSchedulingHintMs = 1000 /* ms */ / pStream->State.uTimerHz;
+
+                if (pStream->State.pCircBuf)
+                {
+                    RTCircBufDestroy(pStream->State.pCircBuf);
+                    pStream->State.pCircBuf = NULL;
+                }
+
+                rc = RTCircBufCreate(&pStream->State.pCircBuf, DrvAudioHlpMilliToBytes(100 /* ms */, &Cfg.Props)); /** @todo Make this configurable. */
+                if (RT_SUCCESS(rc))
+                {
+                    ichac97R3MixerRemoveDrvStreams(pThis, pMixSink, Cfg.enmDir, Cfg.DestSource);
+
+                    rc = ichac97R3MixerAddDrvStreams(pThis, pMixSink, &Cfg);
+                    if (RT_SUCCESS(rc))
+                        rc = DrvAudioHlpStreamCfgCopy(&pStream->State.Cfg, &Cfg);
+                }
 
                 /*