Changeset 76868 in vbox for trunk/src/VBox

Timestamp:

Jan 17, 2019 4:03:30 PM (6 years ago)

Author:

vboxsync

Message:

Audio/DrvAudio: One more bugfix regarding setting device-specific pre-buffering values.

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -3048 +3048 @@
      * Pre-buffering size
      */
-    if (pDrvCfg->uPreBufSizeMs != UINT32_MAX)
+    if (pDrvCfg->uPreBufSizeMs != UINT32_MAX) /* Anything set via global / per-VM extra-data? */
     {
         pCfgReq->Backend.cfPreBuf = DrvAudioHlpMilliToFrames(pDrvCfg->uPreBufSizeMs, &pCfgReq->Props);
         RTStrPrintf(szWhat, sizeof(szWhat), "global / per-VM");
     }
-
-    if (pCfgReq->Backend.cfPreBuf == UINT32_MAX) /* Set default pre-buffering size if nothing explicitly is set. */
-    {
-        /* For pre-buffering to finish the buffer at least must be full one time. */
-        pCfgReq->Backend.cfPreBuf = pCfgReq->Backend.cfBufferSize;
-        RTStrPrintf(szWhat, sizeof(szWhat), "default");
-    }
-    else
-        RTStrPrintf(szWhat, sizeof(szWhat), "device-specific");
+    else /* No, then either use the default or device-specific settings (if any). */
+    {
+        if (pCfgReq->Backend.cfPreBuf == UINT32_MAX) /* Set default pre-buffering size if nothing explicitly is set. */
+        {
+            /* For pre-buffering to finish the buffer at least must be full one time. */
+            pCfgReq->Backend.cfPreBuf = pCfgReq->Backend.cfBufferSize;
+            RTStrPrintf(szWhat, sizeof(szWhat), "default");
+        }
+        else
+            RTStrPrintf(szWhat, sizeof(szWhat), "device-specific");
+    }
 
     LogRel2(("Audio: Using %s pre-buffering size (%RU64ms, %RU32 frames) for stream '%s'\n",